fix(logger): no longer replaces object duplicates with "CIRCULAR" - #229
Merged
cabljac merged 3 commits intoMar 31, 2025
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
CorieW
force-pushed
the
@invertase/fix-logger-circular-removal
branch
4 times, most recently
from
27d850e to
d934708
Compare
March 11, 2025 17:14
CorieW
force-pushed
the
@invertase/fix-logger-circular-removal
branch
from
d934708 to
786cb64
Compare
March 11, 2025 17:15
Copy link
Copy Markdown
Member
Author
|
Failing due to deprecation fixed by #230 |
Sorry, something went wrong.
cabljac
approved these changes
Mar 19, 2025
cabljac
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
lgtm
Sorry, something went wrong.
…-python into @invertase/fix-logger-circular-removal
taeold
approved these changes
Mar 31, 2025
Comment thread
tests/test_logger.py
Outdated
Co-authored-by: Daniel Lee <danielylee@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #228