| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Summary of ChangesHello @taeold, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a critical packaging issue by updating the pyproject.toml configuration to ensure that all necessary subpackages are properly included during the build process. This change leverages setuptools's package discovery mechanism, which is essential for the correct distribution and functionality of the firebase_functions SDK. Additionally, it expands the declared Python version compatibility and includes minor formatting adjustments. Highlights
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here. Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
Sorry, something went wrong.
There was a problem hiding this comment.
The pull request modifies the pyproject.toml file to ensure all subpackages are included in the built package. The changes involve updating the [tool.setuptools] section to use packages.find instead of explicitly listing packages, and some formatting adjustments. I have provided feedback focusing on code correctness and highlighting a potential issue with the ruff configuration.
Sorry, something went wrong.
There was a problem hiding this comment.
could we add a check to the build script to ensure all packages are there?
Sorry, something went wrong.
|
@jhuleatt that's good idea. I'll try to see if there is a way to do this without adding too much burden. For now, merging to help unblock FDC team for their integration. |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
Formatter is causing some churn, but the real diff is:
to make sure that we include all subpackages (e.g. firebase_functions/private and firebase_functions/alerts) in the built package.