Fix #265 by passing options to FirebaseAlertOptions - #266
Conversation
Sorry, something went wrong.
Summary of ChangesHello @nathansamson, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a fix for issue #265 by ensuring that global configuration options are properly propagated to FirebaseAlertOptions instances. The change involves modifying several _endpoint methods in src/firebase_functions/options.py to explicitly pass these global options during the construction of FirebaseAlertOptions, thereby resolving potential configuration discrepancies for Firebase alerts. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here. Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
Sorry, something went wrong.
There was a problem hiding this comment.
Code Review
This pull request aims to propagate runtime options to FirebaseAlertOptions by using _asdict_with_global_options. While this is a good improvement, the current implementation introduces a critical bug in AppDistributionOptions, PerformanceOptions, and CrashlyticsOptions. The app_id is passed twice to the FirebaseAlertOptions constructor when an app_id is provided, which will cause a TypeError. This happens because app_id is passed as an explicit keyword argument while also being present in the dictionary returned by _asdict_with_global_options(). I've provided suggestions to remove the redundant app_id argument to fix this. The change for BillingOptions is correct as it does not have an app_id field.
Sorry, something went wrong.
| alert_type=kwargs["alert_type"], | ||
| app_id=self.app_id, | ||
| **self._asdict_with_global_options() |
There was a problem hiding this comment.
The app_id is passed as an explicit keyword argument, but it will also be present in the dictionary returned by self._asdict_with_global_options() because AppDistributionOptions has an app_id field. This will result in a TypeError for passing app_id twice when self.app_id is not None.
Since _asdict_with_global_options() already includes app_id from self, you can remove the explicit app_id=self.app_id argument.
| alert_type=kwargs["alert_type"], | |
| app_id=self.app_id, | |
| **self._asdict_with_global_options() | |
| alert_type=kwargs["alert_type"], | |
| **self._asdict_with_global_options() |
Sorry, something went wrong.
| alert_type=kwargs["alert_type"], | ||
| app_id=self.app_id, | ||
| **self._asdict_with_global_options() |
There was a problem hiding this comment.
The app_id is passed as an explicit keyword argument, but it will also be present in the dictionary returned by self._asdict_with_global_options() because PerformanceOptions has an app_id field. This will result in a TypeError for passing app_id twice when self.app_id is not None.
Since _asdict_with_global_options() already includes app_id from self, you can remove the explicit app_id=self.app_id argument.
| alert_type=kwargs["alert_type"], | |
| app_id=self.app_id, | |
| **self._asdict_with_global_options() | |
| alert_type=kwargs["alert_type"], | |
| **self._asdict_with_global_options() |
Sorry, something went wrong.
| alert_type=kwargs["alert_type"], | ||
| app_id=self.app_id, | ||
| **self._asdict_with_global_options() |
There was a problem hiding this comment.
The app_id is passed as an explicit keyword argument, but it will also be present in the dictionary returned by self._asdict_with_global_options() because CrashlyticsOptions has an app_id field. This will result in a TypeError for passing app_id twice when self.app_id is not None.
Since _asdict_with_global_options() already includes app_id from self, you can remove the explicit app_id=self.app_id argument.
| alert_type=kwargs["alert_type"], | |
| app_id=self.app_id, | |
| **self._asdict_with_global_options() | |
| alert_type=kwargs["alert_type"], | |
| **self._asdict_with_global_options() |
Sorry, something went wrong.
|
Seems to work from my testing. I'll see about getting this reviewed! |
Sorry, something went wrong.
is the topic running? |
Sorry, something went wrong.
Reviewers
1 more reviewerAt least 1 approving review is required to merge this pull request.
I am not sure if this is a correct fix, but it feels relatively reasonable and also seems to work...