FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix: bug where init isn't called with cors enabled by Bradley-McCallion · Pull Request #272 · firebase/firebase-functions-python · GitHub

/ firebase-functions-python Public

fix: bug where init isn't called with cors enabled - #272

Merged
ajperel merged 2 commits into
firebase:mainfrom
Bradley-McCallion:fix/251
May 11, 2026
ConversationCommits (2)ChecksFiles changed
Merged

fix: bug where init isn't called with cors enabled#272
ajperel merged 2 commits into
firebase:mainfrom
Bradley-McCallion:fix/251

Conversation

Bradley-McCallion commented Mar 7, 2026

Copy link
Copy Markdown
Contributor

Fixes #251

In the code path for when CORs is enabled we simply seem to be missing the _with_init wrapper that is present on the path for when CORs is not enabled. It is assumed this is simply a mistake.

gemini-code-assist Bot commented Mar 7, 2026

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical bug in the handling of HTTP functions with CORS enabled. Previously, functions decorated with @core.init would not have their initialization logic executed when served with CORS, leading to unexpected behavior. The fix ensures that the _with_init wrapper is consistently applied, guaranteeing that all necessary setup code runs regardless of CORS configuration.

Highlights

  • Bug Fix: Corrected an issue where the _with_init wrapper was not applied to HTTP functions when Cross-Origin Resource Sharing (CORS) was enabled, leading to initialization functions not being called.
  • Test Coverage: Introduced a new test case to specifically verify that the init function is correctly invoked for on_request HTTP functions when CORS is configured.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • src/firebase_functions/https_fn.py
    • Wrapped the func call with _core._with_init within the _cross_origin decorator chain to ensure initialization occurs when CORS is enabled.
  • tests/test_https_fn.py
    • Imported CorsOptions from firebase_functions.options.
    • Added test_on_request_calls_init_function_with_cors to validate that the init function is called when on_request is used with CORS.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

google-cla Bot commented Mar 7, 2026

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

gemini-code-assist Bot reviewed Mar 7, 2026
View reviewed changes

gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Code Review

This pull request correctly fixes a bug where the init function was not called for on_request handlers when CORS is enabled. The fix ensures the _with_init wrapper is applied consistently. The addition of a dedicated test case is a great way to verify the fix and prevent regressions. I've included one suggestion for a minor refactoring to improve code clarity and reduce duplication.

CorieW approved these changes Mar 12, 2026
View reviewed changes

CorieW left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM!

Thank you for contributing.

Bradley-McCallion commented Mar 14, 2026

Copy link
Copy Markdown
Contributor Author

LGTM!

Thank you for contributing.

No worries! Do you know how I go about getting this merged? Do I need another approver?

CorieW commented Apr 29, 2026

Copy link
Copy Markdown
Member

Hi @Bradley-McCallion. Sorry for the late response! I'll bring this up in the next meeting. Hopefully we can get this merged.

ajperel reviewed May 5, 2026
View reviewed changes

ajperel left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I'm not too familiar with this codebase so leaning heavily on AI to help do a good review. Let me know if I didn't sufficiently check it's results and sorry if that's the case (I did try hard to convince myself and verify).

Comment thread src/firebase_functions/https_fn.py Outdated
methods=options.cors.cors_methods,
origins=options.cors.cors_origins,
)(func)(request)
)(_core._with_init(func))(request)

ajperel May 5, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I think (with the help of AI) this works, but has high overhead as we don't need to call _with_init or _cross_origin on every request.

Do you think this would work and be more efficient?

def on_request_inner_decorator(func: _C1):
       
        func_with_init = _core._with_init(func)
       
        if options.cors is not None:
            wrapped_func = _cross_origin(
                methods=options.cors.cors_methods,
                origins=options.cors.cors_origins,
            )(func_with_init)
        else:
            wrapped_func = func_with_init

        @_functools.wraps(func)
        def on_request_wrapped(request: Request) -> Response:
            return wrapped_func(request)
        _util.set_func_endpoint_attr(
            on_request_wrapped,
            options._endpoint(func_name=func.__name__),
        )
        return on_request_wrapped

I think this is consistent with oncall below? What do you think?

Bradley-McCallion May 8, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Great spot @ajperel (and AI)! Pushed that change!

fix: make sure we only create the wrapper once at decoration time
e862fe1 
Previously we were doing redundant work on each call when this could be fixed a decoration time with no functional difference
ajperel approved these changes May 11, 2026
View reviewed changes

ajperel left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Looks great. Thank you!

ajperel merged commit 534b3b0 into firebase:main May 11, 2026
8 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

ajperel ajperel approved these changes
CorieW CorieW approved these changes
+1 more reviewer
gemini-code-assist[bot] gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

@init Doesn't seem to run locally before function execution

4 participants

Back | FazBrowse Home | New Git URL