FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix: timestamp parsing for RTDB events by CorieW · Pull Request #273 · firebase/firebase-functions-python · GitHub

fix: timestamp parsing for RTDB events - #273

Merged
ajperel merged 3 commits into
mainfrom
@invertase/fix-timestamp-parsing
May 7, 2026
Merged

fix: timestamp parsing for RTDB events#273
ajperel merged 3 commits into
mainfrom
@invertase/fix-timestamp-parsing

Conversation

CorieW commented Apr 30, 2026
edited
Loading

Copy link
Copy Markdown
Member

Resolves #257

Fixes RTDB event timestamp parsing by centralizing ISO 8601 handling and supporting timestamps without microsecond precision.

Adds coverage for the affected timestamp formats to make sure they keep working.

gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Code Review

This pull request refactors timestamp parsing in Firebase Database functions to use a centralized utility, improving support for various ISO 8601 formats, including those without microsecond precision. It updates db_fn.py to use timestamp_conversion, refactors get_precision_timestamp in util.py for better robustness, and adds comprehensive test cases. Feedback includes correcting the docstring for get_precision_timestamp to reflect its actual return type and improving the error handling in util.py by providing a more descriptive error message and using the walrus operator for conciseness.

Comment thread src/firebase_functions/private/util.py Outdated
CorieW requested a review from a team April 30, 2026 12:19

cabljac left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Lgtm, solid

CorieW marked this pull request as ready for review April 30, 2026 14:59

ajperel left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I think the logic in this is solid, but as I got help from AI reviewing it suggested we could fix a long-standing but and simply the code at the same time. Let me know what you think?

Comment thread src/firebase_functions/private/util.py Outdated

ajperel left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks for updating, this looks great! I appreciate the little optimizations over the AI suggestions.

ajperel merged commit a4eb8fa into main May 7, 2026
11 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ValueError when parsing RTDB timestamps without microseconds in db_fn.py

3 participants


Back | FazBrowse Home | New Git URL