| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
There was a problem hiding this comment.
This pull request refactors timestamp parsing in Firebase Database functions to use a centralized utility, improving support for various ISO 8601 formats, including those without microsecond precision. It updates db_fn.py to use timestamp_conversion, refactors get_precision_timestamp in util.py for better robustness, and adds comprehensive test cases. Feedback includes correcting the docstring for get_precision_timestamp to reflect its actual return type and improving the error handling in util.py by providing a more descriptive error message and using the walrus operator for conciseness.
Sorry, something went wrong.
There was a problem hiding this comment.
Lgtm, solid
Sorry, something went wrong.
There was a problem hiding this comment.
I think the logic in this is solid, but as I got help from AI reviewing it suggested we could fix a long-standing but and simply the code at the same time. Let me know what you think?
Sorry, something went wrong.
There was a problem hiding this comment.
Thanks for updating, this looks great! I appreciate the little optimizations over the AI suggestions.
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
Resolves #257
Fixes RTDB event timestamp parsing by centralizing ISO 8601 handling and supporting timestamps without microsecond precision.
Adds coverage for the affected timestamp formats to make sure they keep working.