FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

feat: add support for VPC direct connect by IzaakGough · Pull Request #299 · firebase/firebase-functions-python · GitHub

/ firebase-functions-python Public

feat: add support for VPC direct connect - #299

Open
IzaakGough wants to merge 4 commits into
mainfrom
@invertase/feat-add-support-for-VPC-direct-connect
ConversationCommits (4)ChecksFiles changed
Open

feat: add support for VPC direct connect#299
IzaakGough wants to merge 4 commits into
mainfrom
@invertase/feat-add-support-for-VPC-direct-connect

Conversation

IzaakGough commented Jun 24, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Fixes #275

This PR adds support for VPC direct connect. These additions help to maintain parity between the Python and JS SDKs.

Testing

Deployed the following function:

from flask import Request, Response, make_response
from firebase_functions import https_fn, options

@https_fn.on_request(
    region="us-central1",
    network_interface=options.NetworkInterface(
        network="default",
        subnetwork="default",
    ),
    vpc_egress=options.VpcEgressSetting.PRIVATE_RANGES_ONLY,
  )
def vpcprobe(request: Request) -> Response:
    return make_response("ok", 200)

Ran

gcloud run services describe vpcprobe --region=us-central1 --format export

Output included:

run.googleapis.com/network-interfaces: '[{"network":"default","subnetwork":"default"}]'
run.googleapis.com/vpc-access-egress: private-ranges-only

Then for the reset path:

Deployed:

from flask import Request, Response, make_response
from firebase_functions import https_fn, options

@https_fn.on_request(
    region="us-central1",
    network_interface=options.RESET_VALUE
  )
def vpcprobe(request: Request) -> Response:
    return make_response("ok", 200)

Ran

gcloud run services describe vpcprobe --region=us-central1 --format export

The following were no longer present in the output

run.googleapis.com/network-interfaces 
run.googleapis.com/vpc-access-egress

gemini-code-assist Bot reviewed Jun 24, 2026
View reviewed changes

gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Code Review

This pull request introduces support for Direct VPC Egress by adding a new NetworkInterface dataclass and a network_interface option to RuntimeOptions and global options. It also adds a vpc_egress alias for vpc_connector_egress_settings, updates manifest generation to handle these new settings, and includes comprehensive unit tests. The review feedback suggests a valuable simplification: removing the vpc_egress alias from resettable_options to avoid default RESET_VALUE population, which in turn simplifies the precedence logic in _endpoint() and allows the removal of an unnecessary test assertion.

Comment thread src/firebase_functions/options.py
Comment thread src/firebase_functions/options.py
Comment thread tests/test_options.py Outdated
IzaakGough marked this pull request as ready for review June 24, 2026 13:15
IzaakGough and others added 2 commits June 30, 2026 10:56
fix: remove vpc_egress from resettable options
30a7798
Update tests/test_options.py
b8b72f4 
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
gemini-code-assist[bot] gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add support for VPC direct connect

2 participants

Back | FazBrowse Home | New Git URL