fix: Closure Compiler ES6 Wildcard import not supported - #370
Merged
jshcrowthe merged 1 commit intoJan 25, 2018
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
This was referenced Dec 12, 2017
jshcrowthe
approved these changes
Dec 19, 2017
jshcrowthe
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
This LGTM but lets get a small repro of #369 before we merge.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Reviewers
1 more reviewer3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closure compiler does not support ES6 Wildcard export.
By declaring each and every export, can Closure Compiler do its magic.
See: #369 For more details