FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fix nodejs builds by Feiyang1 · Pull Request #5400 · firebase/firebase-js-sdk · GitHub

Fix nodejs builds - #5400

Merged
Feiyang1 merged 4 commits into
masterfrom
fei-mjs
Aug 30, 2021
Merged

Fix nodejs builds#5400
Feiyang1 merged 4 commits into
masterfrom
fei-mjs

Conversation

Feiyang1 commented Aug 28, 2021
edited
Loading

Copy link
Copy Markdown
Member

Fixes angular/angularfire#2903

  • Fix cjs build of app-compat, so it works with mjs import in Nodejs/bundlers
  • Expose firestore/lite in Nodejs by defining the exports field

changeset-bot Bot commented Aug 28, 2021

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 7db1aac

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
@firebase/analytics-compat Patch
@firebase/app-check-compat Patch
@firebase/app-compat Patch
@firebase/functions-compat Patch
@firebase/firestore Patch
firebase Patch
@firebase/firestore-compat Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Copy Markdown
Member Author

@jamesdaniels fyi

Copy link
Copy Markdown
Contributor

Changeset File Check ⚠️

  • Warning: This PR modifies files in the following packages but they have not been included in the changeset file:

    • @firebase/analytics-compat
    • @firebase/app-check-compat
    • @firebase/app-compat
    • @firebase/functions-compat

    Make sure this was intentional.

Copy link
Copy Markdown
Collaborator

Size Analysis Report

Affected Products

No changes between base commit (509c18f) and head commit (3588e138).

Feiyang1 merged commit cd15df0 into master Aug 30, 2021
Feiyang1 deleted the fei-mjs branch August 30, 2021 17:37
google-oss-bot mentioned this pull request Aug 30, 2021
firebase locked and limited conversation to collaborators Sep 30, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SSR fails after update to v7 using ng-update "_firebase_app_compat__WEBPACK_IMPORTED_MODULE_0__.registerVersion is not a function"

3 participants


Back | FazBrowse Home | New Git URL