FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Enable encodeInitMessageHeaders by schmidt-sebastian · Pull Request #6107 · firebase/firebase-js-sdk · GitHub

Enable encodeInitMessageHeaders - #6107

Merged
MarkDuckworth merged 7 commits into
masterfrom
mrschmidt/initflag
Sep 7, 2022
Merged

Enable encodeInitMessageHeaders#6107
MarkDuckworth merged 7 commits into
masterfrom
mrschmidt/initflag

Conversation

Copy link
Copy Markdown
Contributor

This transitions the Firestore client from encoding HTTP Headers via the Query Param to the request's POST payload.

changeset-bot Bot commented Mar 30, 2022
edited
Loading

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 9f9f553

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@firebase/firestore Minor
@firebase/webchannel-wrapper Minor
firebase Patch
@firebase/firestore-compat Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

google-oss-bot commented Mar 30, 2022
edited
Loading

Copy link
Copy Markdown
Collaborator

Size Report 1

Affected Products

  • @firebase/firestore

    TypeBase (37a8abd)Merge (504ce8a)Diff
    browser264 kB264 kB-237 B (-0.1%)
    esm5327 kB327 kB-188 B (-0.1%)
    module264 kB264 kB-237 B (-0.1%)
    react-native264 kB264 kB-233 B (-0.1%)
  • @firebase/webchannel-wrapper

    TypeBase (37a8abd)Merge (504ce8a)Diff
    esm544.7 kB44.6 kB-69 B (-0.2%)
    main50.8 kB54.6 kB+3.72 kB (+7.3%)
    module43.2 kB42.3 kB-810 B (-1.9%)
  • bundle

    TypeBase (37a8abd)Merge (504ce8a)Diff
    firestore (Persistence)274 kB273 kB-1.49 kB (-0.5%)
    firestore (Query Cursors)211 kB209 kB-1.63 kB (-0.8%)
    firestore (Query)212 kB210 kB-1.63 kB (-0.8%)
    firestore (Read data once)201 kB199 kB-1.63 kB (-0.8%)
    firestore (Realtime updates)203 kB201 kB-1.63 kB (-0.8%)
    firestore (Transaction)184 kB183 kB-1.63 kB (-0.9%)
    firestore (Write data)184 kB183 kB-1.63 kB (-0.9%)
  • firebase

    TypeBase (37a8abd)Merge (504ce8a)Diff
    firebase-compat.js739 kB738 kB-855 B (-0.1%)
    firebase-firestore-compat.js314 kB313 kB-1.24 kB (-0.4%)
    firebase-firestore.js313 kB311 kB-1.33 kB (-0.4%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/KcanH23YXv.html

google-oss-bot commented Mar 30, 2022
edited
Loading

Copy link
Copy Markdown
Collaborator

Size Analysis Report 1

This report is too large (989,644 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/2Y4n0igFbi.html

Copy link
Copy Markdown
Contributor Author

FWIW we cannot merge this yet as this requires Emulator support.

MarkDuckworth and others added 3 commits September 2, 2022 14:50
Modified the change type from 'patch' to 'minor'. There is no change to the public API and no feature added, but the change does require an update to the emulator. We feel that a patch may go unnoticed.
MarkDuckworth merged commit 7c0c640 into master Sep 7, 2022
MarkDuckworth deleted the mrschmidt/initflag branch September 7, 2022 19:24
google-oss-bot mentioned this pull request Sep 14, 2022
firebase locked and limited conversation to collaborators Oct 8, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants


Back | FazBrowse Home | New Git URL