FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fix websocketonly flag by maneesht · Pull Request #6126 · firebase/firebase-js-sdk · GitHub

/ firebase-js-sdk Public

Fix websocketonly flag - #6126

Merged
maneesht merged 13 commits into
masterfrom
fix-websocketonly-flag
Apr 8, 2022
ConversationCommits (13)ChecksFiles changed
Merged

Fix websocketonly flag#6126
maneesht merged 13 commits into
masterfrom
fix-websocketonly-flag

Conversation

maneesht commented Apr 6, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

Fixes an issue where the webSocketOnly field was incorrectly set to undefined when using a websocket database URL.

When initializing the RepoInfo instance, the nodeAdmin value was being passed in as the webSocketOnly value, leading webSocketOnly to be undefined even when using a websocket url.

changeset-bot Bot commented Apr 6, 2022 •
edited
Loading

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: f058ac3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@firebase/database Patch
@firebase/database-compat Patch
firebase Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

maneesht requested a review from egilmorez as a code owner April 6, 2022 20:36

google-oss-bot commented Apr 6, 2022 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Size Report 1

Affected Products

No changes between base commit (d756f4e) and merge commit (9146618).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/ltZwz06zPc.html

maneesht marked this pull request as draft April 6, 2022 20:59

google-oss-bot commented Apr 6, 2022 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Size Analysis Report 1

Affected Products

No changes between base commit (d756f4e) and merge commit (9146618).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/HyfqeCQ5Bq.html

jsdt reviewed Apr 6, 2022
View reviewed changes
Comment thread .changeset/twenty-shoes-cheer.md Outdated
"@firebase/database": patch
---

Fix websocketonly field to be set to true when using websocket db url.

jsdt Apr 6, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Could you explain what the websocket url is in parens (ws or wss instead of https)? Then someone can figure out how to use it by reading the release notes.

maneesht marked this pull request as ready for review April 6, 2022 22:22
maneesht requested a review from jsdt April 7, 2022 18:18
schmidt-sebastian self-assigned this Apr 7, 2022
schmidt-sebastian approved these changes Apr 8, 2022
View reviewed changes
Comment thread packages/database/test/parser.test.ts Outdated
@@ -0,0 +1,34 @@
/**
* @license
* Copyright 2017 Google LLC

schmidt-sebastian Apr 8, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

2022

maneesht merged commit 7a4e65c into master Apr 8, 2022
maneesht deleted the fix-websocketonly-flag branch April 8, 2022 20:05
google-oss-bot mentioned this pull request Apr 12, 2022
Merged
firebase locked and limited conversation to collaborators May 9, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

hsubox76 hsubox76 approved these changes
allspain Awaiting requested review from allspain
egilmorez Awaiting requested review from egilmorez
+2 more reviewers
jsdt jsdt approved these changes
schmidt-sebastian schmidt-sebastian approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

maneesht

Labels

api: database

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL