Fix proactive refresh logic, add some tests - #6544
Merged
sam-gc merged 2 commits intoAug 19, 2022
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
🦋 Changeset detectedLatest commit: 437c652 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Size Report 1Affected Products
Test Logs |
Sorry, something went wrong.
maneesht
approved these changes
Aug 18, 2022
maneesht
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM. Thanks for doing this!
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Size Analysis Report 1Affected Products
Test Logs |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
/lgtm Thanks for fixing! |
Sorry, something went wrong.
yuchenshi
approved these changes
Aug 19, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We noticed the logic in the proactive refresh code was not quite correct (it wasn't turning on for newly-signed-in users). Turns out we also never tested this. D'oh! I've added some tests and walked through the code with Maneesh and I think this puts us in a better spot.