FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix documentation typo by tylim88 · Pull Request #6583 · firebase/firebase-js-sdk · GitHub

fix documentation typo - #6583

Merged
maneesht merged 4 commits into
firebase:masterfrom
tylim88:master
Oct 3, 2022
Merged

fix documentation typo#6583
maneesht merged 4 commits into
firebase:masterfrom
tylim88:master

Conversation

tylim88 commented Sep 5, 2022

Copy link
Copy Markdown
Contributor

push typo

endBefore typo

changeset-bot Bot commented Sep 5, 2022
edited
Loading

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: f3fb67b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@firebase/database Patch
@firebase/database-compat Patch
firebase Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

tylim88 changed the title fix typo of documentation in code fix documentation typo Sep 6, 2022
maneesht requested a review from egilmorez as a code owner September 7, 2022 20:36

maneesht commented Sep 7, 2022

Copy link
Copy Markdown
Contributor

@tylim88 - can you please fix the formatting issue?

egilmorez left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LG from a docs perspective, thanks for catching and sending!

maneesht merged commit 5aa48d0 into firebase:master Oct 3, 2022
google-oss-bot mentioned this pull request Oct 10, 2022
firebase locked and limited conversation to collaborators Nov 3, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants


Back | FazBrowse Home | New Git URL