Expose TOKEN_EXPIRED error upon mfa unenroll. - #6973
Merged
prameshj merged 2 commits intoJan 24, 2023
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
🦋 Changeset detectedLatest commit: 6d22568 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Sorry, something went wrong.
prameshj
force-pushed
the
multiple-mfa-unenroll
branch
from
6e85974 to
1c1668a
Compare
January 24, 2023 01:07
Copy link
Copy Markdown
Collaborator
Size Report 1Affected Products
Test Logs |
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Size Analysis Report 1Affected Products
Test Logs |
Sorry, something went wrong.
sam-gc
approved these changes
Jan 24, 2023
sam-gc
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
This looks good, thanks!
Sorry, something went wrong.
prameshj
force-pushed
the
multiple-mfa-unenroll
branch
from
1c1668a to
560ae9f
Compare
January 24, 2023 18:54
prameshj
marked this pull request as ready for review
January 24, 2023 18:54
prameshj
requested review from
avolkovi,
egilmorez,
lisajian and
yuchenshi
as code owners
January 24, 2023 18:54
prameshj
force-pushed
the
multiple-mfa-unenroll
branch
from
560ae9f to
1479187
Compare
January 24, 2023 19:29
This can be thrown if the MFA option that was most recently enrolled into, was unenrolled. The user will be logged out to prove the posession of the other second factor. This error can be handled by reauthenticating the user. This change also updates the demo app to store the lastUser in case mfa unenroll logs out the user. From here, the lastUser can be reauthenticated.
prameshj
force-pushed
the
multiple-mfa-unenroll
branch
from
1479187 to
6d22568
Compare
January 24, 2023 20:03
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This can be thrown if the MFA option that was most recently enrolled into, was unenrolled. The user will be logged out to prove the posession of the other second factor. This error can be handled by reauthenticating the user.
This change also updates the demo app to store the lastUser in case mfa unenroll logs out the user. From here, the lastUser can be reauthenticated.