Change _fail to use AuthErrorCode.INTERNAL_ERROR and pass in error me… - #7038
Merged
NhienLam merged 2 commits intoFeb 15, 2023
Merged
Change _fail to use AuthErrorCode.INTERNAL_ERROR and pass in error me…#7038NhienLam merged 2 commits into
NhienLam merged 2 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
NhienLam
requested review from
lisajian,
renkelvin and
sam-gc
as code owners
February 14, 2023 23:36
Copy link
Copy Markdown
🦋 Changeset detectedLatest commit: 19b78a6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Sorry, something went wrong.
prameshj
approved these changes
Feb 14, 2023
Copy link
Copy Markdown
Collaborator
Size Report 1Affected Products
Test Logs |
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Size Analysis Report 1Affected Products
Test Logs |
Sorry, something went wrong.
sam-gc
approved these changes
Feb 15, 2023
Merged
renkelvin
pushed a commit
that referenced
this pull request
Mar 2, 2023
#7038) * Change _fail to use AuthErrorCode.INTERNAL_ERROR and pass in error messsage * Add changeset
Copy link
Copy Markdown
|
@NhienLam we just upgraded to this version and we're seeing our users get logged out whenever the network changes. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Reviewers
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, auth/network-request-failed is caused by many different issues. After this change, if someone sees a auth/network-request-failed error, then it means the API call timed out (
firebase-js-sdk/packages/auth/src/api/index.ts
Line 141 in 04dcdbb
firebase-js-sdk/packages/auth/src/api/index.ts
Line 234 in 04dcdbb
Other failures will be thrown with AuthErrorCode.INTERNAL_ERROR and an error message.