FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

update data connect client, dataplaneclient, and emulator client to v… by hlshen · Pull Request #7589 · firebase/firebase-tools · GitHub

update data connect client, dataplaneclient, and emulator client to v… - #7589

Merged
hlshen merged 7 commits into
masterfrom
hlshen/v1beta
Sep 18, 2024
Merged

update data connect client, dataplaneclient, and emulator client to v…#7589
hlshen merged 7 commits into
masterfrom
hlshen/v1beta

Conversation

hlshen commented Aug 23, 2024
edited
Loading

Copy link
Copy Markdown
Member

Do not release until emulator updates endpoints

hlshen requested a review from joehan August 23, 2024 17:47
hlshen marked this pull request as draft August 23, 2024 19:33

joehan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Tests in dataconnect/client.spec.ts are failing - looks like you just need to update the references to v1alpha in there as well.

hlshen requested a review from joehan September 3, 2024 16:52
hlshen marked this pull request as ready for review September 3, 2024 16:52
hlshen merged commit c222f52 into master Sep 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL