Implement schemaValidation mode handling in dataconnect:sql:migrate and deploy - #7639
Merged
rosalyntan merged 14 commits intoSep 16, 2024
Merged
Implement schemaValidation mode handling in dataconnect:sql:migrate and deploy#7639rosalyntan merged 14 commits into
rosalyntan merged 14 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
rosalyntan
marked this pull request as ready for review
September 14, 2024 01:38
joehan
reviewed
Sep 16, 2024
Comment thread
src/commands/dataconnect-sql-migrate.ts
| options, | ||
| schema: serviceInfo.schema, | ||
| validateOnly: true, | ||
| schemaValidation: serviceInfo.dataConnectYaml.schema.datasource.postgresql?.schemaValidation, |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Quick sanity check - does this get broken by our move from datasource -> datasources? @fredzqm might know off the top of his head.
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
There was a problem hiding this comment.
Chatted offline -- based on go/fdc:multi-data-source it looks like the datasource field will still be supported, though we should also support datasources in #7589.
Sorry, something went wrong.
joehan
approved these changes
Sep 16, 2024
Comment thread
src/dataconnect/schemaMigration.ts
Outdated
Comment thread
src/dataconnect/schemaMigration.ts
Outdated
rosalyntan
enabled auto-merge (squash)
September 16, 2024 22:24
pr-Mais
pushed a commit
that referenced
this pull request
Sep 19, 2024
…e` and `deploy` (#7639) * Support handling schema validation options in `diff`. * Format. * Don't output second set of diffs if they're equal to the first. * Update dataconnect:sql:migrate * Fix my failed rebase lol * Finish handling schemaValidation mode in `dataconnect:sql:migrate`. * Fix setSchemaValidationMode. * Concat follow-up strict diffs, instead of replacing compat diffs. * Don't display purely optional changes with flag. * Pass `schemaValidation` into `deploy` command. * Address review comments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updates firebase dataconnect:sql:migrate and firebase deploy per go/fdc-compat-mode-cli-api.
Scenarios Tested
schemaValidation unset, both required and optional changes:
schemaValidation unset, only required changes:
schemaValidation unset, only optional changes:
schemaValidation=COMPATIBLE, both required and optional changes:
schemaValidation=COMPATIBLE, only optional changes:
schemaValidation=STRICT, both required and optional changes:
Sample Commands
firebase deploy, with schemaValidation unset, both required and optional changes, and default options selected:
