Increases timeout for function operations. - #3150
Merged
mbleigh merged 2 commits intoFeb 22, 2021
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
|
yes please merge and release a new version - thank you! it times out almost every time :( |
Sorry, something went wrong.
taeold
self-requested a review
February 22, 2021 16:43
taeold
approved these changes
Feb 22, 2021
Copy link
Copy Markdown
Member
|
LGTM - sorta duplicates #3148, but i think we want to merge that one as well since it has another small bugfix. |
Sorry, something went wrong.
joehan
approved these changes
Feb 22, 2021
Copy link
Copy Markdown
Contributor
Author
|
Ah, I didn't see that you already had a pending PR for this. How about you edit your PR to just be about the other change (and I'll keep this one since 25m is the backend timeout)? |
Sorry, something went wrong.
devpeerapong
pushed a commit
to devpeerapong/firebase-tools
that referenced
this pull request
Dec 14, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A customer reported issues with deploys timing out. When I asked them to investigate closer, it appears that the CLI is timing out but the build does eventually succeed. Increasing the operation timeout to the actual backend limit to avoid false failures.
Fixes #3147