Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
samtstern
reviewed
Feb 24, 2021
Comment thread
src/emulator/controller.ts
| ); | ||
| if (options.only) { | ||
| const requested: string[] = options.only.split(","); | ||
| const onlyOptions: string = options.only; |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Do we have to repeat this code block twice?
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
There was a problem hiding this comment.
Yes. It likely can be refactored in the future, but since it's more lines to refactor than it would be to duplicate, I'm leaving it as-written.
Sorry, something went wrong.
samtstern
approved these changes
Feb 24, 2021
devpeerapong
pushed a commit
to devpeerapong/firebase-tools
that referenced
this pull request
Dec 14, 2021
* fixes issue with hosting emulator targets * formatting is hard
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #2820
Scenarios Tested