Storage Emulator "Fast-Follow" Bug Fixes - #3403
Conversation
Sorry, something went wrong.
| } | ||
|
|
||
| private deleteFieldsSetAsNull() { | ||
| const deletableFields: (keyof this)[] = [ |
There was a problem hiding this comment.
I just learned a new trick!
Sorry, something went wrong.
|
|
||
| if (this.customMetadata) { | ||
| Object.keys(this.customMetadata).map((key: string) => { | ||
| if (!this.customMetadata) return; |
There was a problem hiding this comment.
This if seems to conflict with the outer if(this.customMetadata) ...
Sorry, something went wrong.
There was a problem hiding this comment.
it doesn't conflict cause it's saying "if I have custom metadata do this" then "if I dont have custom metadata dont do this" but it is weird cause it's like a double check. I had to add this cause typescript was getting confused and ignoring my explicit check of this.customMetadata in the outer if thinking it could still be undefined in the inner one so I had to check again.
Tho it occurs to me that if I use a for look it'll probably fix this so I'll probably just do that.
Sorry, something went wrong.
See Changelog.md for details.