FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Remove development-only files from Next.js deployments by leoortizz · Pull Request #6731 · firebase/firebase-tools · GitHub

Remove development-only files from Next.js deployments - #6731

Merged
leoortizz merged 18 commits into
masterfrom
leoortizz_rmNextjsDevFilesForProd
Apr 4, 2024
Merged

Remove development-only files from Next.js deployments#6731
leoortizz merged 18 commits into
masterfrom
leoortizz_rmNextjsDevFilesForProd

Conversation

leoortizz commented Jan 31, 2024
edited
Loading

Copy link
Copy Markdown
Member

Description

Remove development-only files from deployed files. Closes #6715

Scenarios Tested

see test case added in 1f579d7

Sample Commands

codecov-commenter commented Feb 27, 2024
edited
Loading

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 20.00000% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 54.56%. Comparing base (cecf08b) to head (b6b946d).

Files Patch % Lines
src/frameworks/next/utils.ts 28.57% 5 Missing ⚠️
src/frameworks/next/index.ts 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6731      +/-   ##
==========================================
- Coverage   54.56%   54.56%   -0.01%     
==========================================
  Files         355      355              
  Lines       24723    24731       +8     
  Branches     5107     5108       +1     
==========================================
+ Hits        13490    13494       +4     
- Misses      10013    10017       +4     
  Partials     1220     1220              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment thread src/frameworks/next/utils.ts Outdated

Copy link
Copy Markdown
Contributor

Would be great if we didn't copy those files to start with but that would probably make the code more complex, wdyt?

Copy link
Copy Markdown
Member Author

Would be great if we didn't copy those files to start with but that would probably make the code more complex, wdyt?

indeed, I can make that change. I thought it would be slower than just removing the files but it's probably similar

leoortizz marked this pull request as ready for review February 28, 2024 22:37
leoortizz changed the title remove dev files from dist dir for prod deployments Remove development-only files from Next.js deployments Feb 28, 2024
leoortizz enabled auto-merge (squash) March 9, 2024 14:32
leoortizz force-pushed the leoortizz_rmNextjsDevFilesForProd branch from b2bb50e to 48d1f51 Compare April 4, 2024 15:26
leoortizz merged commit c92c91a into master Apr 4, 2024
leoortizz deleted the leoortizz_rmNextjsDevFilesForProd branch April 4, 2024 17:02
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Web frameworks - Next.js - Functions deployment is huge due to .next/cache

3 participants


Back | FazBrowse Home | New Git URL