Improve error message thrown when missing permission to deploy to hosting - #7490
Merged
joehan merged 5 commits intoJul 30, 2024
Merged
Improve error message thrown when missing permission to deploy to hosting#7490joehan merged 5 commits into
joehan merged 5 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
joehan
self-requested a review
July 24, 2024 21:32
Copy link
Copy Markdown
Contributor
Author
|
Oops, didn’t realize I put the wrong log messages in the initial comment. Updated it from Error: Assertion failed: resolving hosting target of a site with no site name or target name. This should have caused an error earlier to Error: Failed to get Firebase project invalid-project-name-2358923. Please make sure the project exists and your account has permission to access it. |
Sorry, something went wrong.
Berlioz
approved these changes
Jul 29, 2024
joehan
enabled auto-merge (squash)
July 30, 2024 18:05
kmcnellis
approved these changes
Jul 30, 2024
joehan
approved these changes
Jul 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #7190
Scenarios Tested
Using the test case provided in #7190
Using an logged in account deploying to a project it has no access to
Note: Using a valid service-account and project
Sample Commands