fix: update updateRulesWithClient in realtime-database to include src - #8986
fix: update updateRulesWithClient in realtime-database to include src#8986joehan merged 2 commits into
Conversation
Sorry, something went wrong.
There was a problem hiding this comment.
Summary of Changes
Hello @ryzizub, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request addresses a bug in the Realtime Database rules deployment process. Previously, the src parameter was not being passed to the updateRulesWithClient function, leading to incorrect rule deployments. The change ensures that the source of the Realtime Database rules is properly included during deployment, resolving the issue.
Highlights
- Realtime Database Rules Deployment Fix: Modified the updateRules function in src/rtdb.ts to correctly pass the src parameter to the updateRulesWithClient function, resolving an issue with deploying Realtime Database rules.
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review | Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary | Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help | Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
Sorry, something went wrong.
There was a problem hiding this comment.
Code Review
This pull request fixes a bug where the realtime database rules source was not being passed correctly during deployment. The change in src/rtdb.ts correctly adds the src parameter to the updateRulesWithClient function call, which resolves the issue of deployments failing with a syntax error for undefined rules. The fix is correct and addresses the problem described.
Sorry, something went wrong.
|
@antholeole looks like this bug was introduced in #8854 - can you please give this fix PR a review? |
Sorry, something went wrong.
antholeole
left a comment
There was a problem hiding this comment.
Thanks and sorry about that!
Sorry, something went wrong.
… parameter
Description
I updated to latest version of firebase-tools and had troubles deploying the realtime database rules. Find out that source of realtime database is not included so those are incorrectly passed
Same issue is mentioned here #8985
Scenarios Tested
Sample Commands
I did firebase deploy only
Before:
After:
