Auto-update dependencies. - #2829
Conversation
Sorry, something went wrong.
Wiz Scan Summary
To detect these findings earlier in the dev lifecycle, try the Wiz Code extension for VS Code, JetBrains, or Visual Studio. |
Sorry, something went wrong.
There was a problem hiding this comment.
Code Review
This pull request updates the ktlint dependency from version 0.49.1 to 0.50.0 in build.gradle.kts. The reviewer pointed out that this upgrade introduces breaking changes to CLI arguments, which will cause the ktlintCheck task to fail, and provided a code suggestion to update the task arguments accordingly.
Sorry, something went wrong.
|
|
||
| dependencies { | ||
| ktlint("com.pinterest:ktlint:0.49.1") { | ||
| ktlint("com.pinterest:ktlint:0.50.0") { |
There was a problem hiding this comment.
Upgrading to ktlint 0.50.0 introduces breaking changes to the CLI arguments, which will cause the ktlintCheck task (defined on lines 32-56) to fail.
Specifically, in ktlint 0.50.0:
- The --format option has been removed. Formatting is now performed using the format subcommand.
- The --code-style option has been removed. The code style must now be defined in the .editorconfig file using ktlint_code_style = android_studio.
To fix this, you will need to update the ktlintCheck task arguments. For example, to perform a lint check (without formatting):
args(
"lint",
"--reporter=plain",
"--reporter=checkstyle,output=${outputFile}",
"**/*.kt",
"!**/build/**"
)And ensure that ktlint_code_style = android_studio is set in your .editorconfig file.
Sorry, something went wrong.
Brought to you by your friendly Repository Gardener.