feat: add AdaL as a supported harness agent - #171
Draft
Ricardoran wants to merge 1 commit into
Draft
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
Ricardoran
force-pushed
the
add-adal-agent
branch
from
14bb32f to
4431e10
Compare
July 28, 2026 21:43
Adds AdaL to the native agent detection registry so that `firecrawl init --agent adal` and `firecrawl init --all` install skills into ~/.adal/skills/. - Registry entry: name='adal', detectDir='.adal', globalSkillsDir='.adal/skills' - Non-destructive collision guard: existing user-owned directories and files at skill link paths are NEVER overwritten (only stale symlinks are replaced). Skipped collisions emit a warning. - Guard is generic (protects all harnesses equally), tested against both adal and codex harnesses. - README: harness table entry + section distinguishing native bootstrap from AdaL marketplace install + collision safety documentation - Tests: 13 focused assertions covering detection, isolation, SKILL.md validity, collision preservation (dir + file for adal AND codex), stale symlink replacement, idempotence, and error handling Co-Authored-By: AdaL <adal@sylph.ai>
Ricardoran
force-pushed
the
add-adal-agent
branch
from
4431e10 to
918b131
Compare
July 28, 2026 21:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds AdaL as a supported harness in the native agent detection registry, with a non-destructive collision guard that never overwrites user-owned skill directories or files.
Changes
How it works
Collision safety (non-destructive by default)
The symlink-creation phase now handles existing paths as follows:
This ensures init --agent adal (including non-interactive mode) never destroys user-authored content at ~/.adal/skills/<skill-name>.
The guard is generic — it protects all harnesses equally (not AdaL-specific). Cross-harness behavior is proven by dedicated Codex collision tests.
AdaL's skill discovery
AdaL's SkillsLoader scans ~/.adal/skills/ for directories containing SKILL.md files with YAML frontmatter (name + description). All Firecrawl CLI skills satisfy this format.
AdaL also has a separate marketplace-based install path (/plugin marketplace add firecrawl/cli) that places skills in ~/.adal/plugin-cache/. The README documents both paths so users can choose — they use different install locations and precedence rules.
Test results
✓ assertion 3+5: adal agent is registered with correct detectDir and globalSkillsDir ✓ assertion 7: auto-detection recognizes existing .adal directory ✓ assertion 8+9: isolated install succeeds and places artifacts in .adal/skills ✓ assertion 10: every installed skill has valid SKILL.md with name+description ✓ assertion 11: preserves pre-existing user-owned skill files with non-conflicting names ✓ assertion 12: idempotent reinstall produces stable result ✓ assertion 13: collision — same-named user directory is preserved, NOT overwritten ✓ assertion 13b: collision — same-named user file is preserved, NOT overwritten ✓ assertion 13c: stale symlinks ARE safely replaced ✓ assertion 14: unwritable destination causes error, no corrupt partial state ✓ assertion 15: paths resolve under isolated HOME, not real HOME ✓ [codex] preserves same-named user-owned directory for codex harness ✓ [codex] preserves same-named user-owned file for codex harness Test Files 23 passed | 1 skipped (24) Tests 403 passed | 1 skipped (404)All existing tests pass with zero regressions.
Scope of collision guard
The non-destructive guard is applied generically in the installSkillsNative symlink phase (not AdaL-specific). It protects all harnesses equally — any agent with an existing user-owned skill at a same-named path will have it preserved. This is proven by the cross-harness Codex collision tests.
Licensing note
This PR adds only a registry entry pointing to AdaL's existing ~/.adal/skills/ directory convention. No Firecrawl content is redistributed by AdaL.