Fix skill-scoped installs installing the whole catalog - #209
Merged
ericciarla merged 1 commit intoAug 21, 2026
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
skills add --all means "ALL skills to all agents" and silently overrides any --skill filter, so every scoped install (setup core/build/workflows, setup <skill>, and init's selections) was installing all 33 catalog skills. Scoped installs now pass --yes instead of --all: same promptless install to every detected agent, but the --skill list is respected. Verified: setup developer-index installs 1 skill, setup build installs 5. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug (user-reported): npx -y firecrawl-cli@latest setup developer-index installed all 33 catalog skills instead of one.
Cause: buildSkillsInstallArgs passes --all whenever no --agent is given — but the skills CLI defines --all as "install all skills to all agents without prompts", which silently overrides the --skill filter. Reproduced with the raw skills CLI: --all --skill firecrawl-developer-index → 33 skills; --yes --skill firecrawl-developer-index → 1 skill.
Scope: worse than the new single-skill command — every skill-scoped install had this: setup core (12→33), setup build (5→33), setup workflows (16→33), and init's selections. It went unnoticed because extra skills fail quietly; 1→33 made it obvious.
Fix: skill-scoped installs never pass --all; they pass --yes instead — same promptless install to every detected agent, with the --skill list respected. Whole-repo installs are unchanged.
Verified: built CLI in a fresh $HOME — setup developer-index installs exactly 1 skill, setup build exactly 5; 431/431 tests pass (expectations updated), tsc + prettier clean.
Needs a patch release to ship — see the follow-up release: 1.23.1 PR (merge that after this).
🤖 Generated with Claude Code
Summary by cubic
Fixes skill-scoped installs that were installing the entire catalog by incorrectly passing --all. Skill-scoped installs now pass --yes, which respects the --skill filter; whole-repo installs are unchanged.
Written for commit d53a939. Summary will update on new commits.