feat(cli): remove audit-list - #950
Open
davidfrigolet wants to merge 3 commits into
Open
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
bercianor
previously approved these changes
Aug 12, 2026
bercianor
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
There is a problem. We are removing two operationsÑ audit list and state. `` |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
There is a problem: With this change we are removing the audit list but also the audit state. AuditListOperation.java:36-38 List<AuditEntry> entries = args.isHistory()
? auditReader.getAuditHistory()
: auditReader.getAuditSnapshot();I know the trello ticket says to remove all those files, but it´s wrong...My mistake. On the other hand, I am wondering if we should keep the audit ist also, but throwing a message that is an enterprise feature 🤔 |
Sorry, something went wrong.
Restores the AUDIT_LIST operation type, args/result/response classes,
and OperationResolver wiring removed in a prior commit. Per PR review,
removing the whole operation also removed the snapshot ("state") mode,
not just the history listing.
AuditListOperation.execute() now throws UnsupportedOperationException,
gating the feature behind Cloud/Self-Hosted Edition instead of exposing
full audit-store read behavior in Community Edition.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
At least 1 approving review is required to merge this pull request.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat(cli): remove audit-list