FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fix conflicts with boost placeholders by snoe925 · Pull Request #18 · flightaware/cpptcl · GitHub

Fix conflicts with boost placeholders - #18

Merged
snoe925 merged 1 commit into
masterfrom
placeholders
Oct 24, 2019
Merged

Fix conflicts with boost placeholders#18
snoe925 merged 1 commit into
masterfrom
placeholders

Conversation

snoe925 commented Oct 21, 2019

Copy link
Copy Markdown
Contributor

Remove using namespace in methods.h header.
The user should get to select the namespace for _1, _2, ...

Remove using namespace in methods.h header.
The user should get to select the namespace for _1, _2, ...
snoe925 requested a review from pm-conej October 21, 2019 20:06

Copy link
Copy Markdown

👍
using namespace should basically never be in headers to avoid this type of problem

conej730 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Now we just need to see if we can take variable arguments in here

snoe925 merged commit f547585 into master Oct 24, 2019
snoe925 deleted the placeholders branch October 24, 2019 03:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants


Back | FazBrowse Home | New Git URL