Golden ratio - #43
Open
raoulb wants to merge 3 commits into
Open
Golden ratio#43raoulb wants to merge 3 commits into
raoulb wants to merge 3 commits into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
added 3 commits
October 28, 2022 21:26
Note: As calcium resolves quadratic fields, we still get phi
explicitly as Q(sqrt(5)) instead of Q(a) with a^2-a-1 = 0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As briefly mentioned in PR #42 I tried to streamline the golden ratio a bit.
Most interesting part might be the explicit public API function ca_phi.
Feel free to cherry-pick what you find useful.