Declare build deps in `pyproject.toml` by mkoeppe · Pull Request #108 · flintlib/python-flint · GitHub

No description provided.

Thanks. I had been thinking about doing this for a while but I wasn't sure about all implications given that setup.py uses distutils rather than setuptools (for Python < 3.12). I guess it is fine to call the backend setuptools in any case.

This should fix pip install for the special case that compilers and flint are already installed but a python-flint wheel is not available and should mean that --no-build-isolation is not needed any more.

There is also discussion about pyproject.toml in gh-52. Another thing that would be good to move to pyproject.toml would be all the cibuildwheel config which is currently duplicated in CI config/scripts:

python-flint/.github/workflows/buildwheel.yml

Lines 36 to 53 in e5da576

    
                   env: 
        
                     CIBW_BUILD: cp39-* cp310-* cp311-* cp312-* 
        
                     CIBW_SKIP: "*-win32 *-manylinux_i686 *-musllinux_*" 
        
                     CIBW_MANYLINUX_X86_64_IMAGE: manylinux2014 
        
                     CIBW_MANYLINUX_I686_IMAGE: manylinux2014 
        
                     CIBW_BEFORE_ALL_LINUX: bin/cibw_before_all_linux.sh 
        
                     CIBW_BEFORE_ALL_MACOS: bin/cibw_before_all_macosx_x86_64.sh 
        
                     CIBW_BEFORE_ALL_WINDOWS: msys2 -c bin/cibw_before_all_windows.sh 
        
                     CIBW_BEFORE_BUILD_WINDOWS: msys2 -c bin/cibw_before_build_windows.sh 
        
                     CIBW_BEFORE_BUILD: pip install numpy setuptools cython delvewheel 
        
                     CIBW_ENVIRONMENT: > 
        
                       C_INCLUDE_PATH=$(pwd)/.local/include/ 
        
                       LIBRARY_PATH=$(pwd)/.local/lib/ 
        
                       LD_LIBRARY_PATH=$(pwd)/.local/lib:$LD_LIBRARY_PATH 
        
                       PYTHON_FLINT_MINGW64=true 
        
                     CIBW_REPAIR_WHEEL_COMMAND_WINDOWS: >- 
        
                       bin\cibw_repair_wheel_command_windows.bat {dest_dir} {wheel} 
        
                     CIBW_TEST_COMMAND: python -c "import flint; print(str(flint.fmpz(2)))"

python-flint/bin/cibw.sh

Lines 12 to 36 in e5da576

    
           export CIBW_ENVIRONMENT='C_INCLUDE_PATH=$(pwd)/.local/include/ LIBRARY_PATH=$(pwd)/.local/lib/ LD_LIBRARY_PATH=$(pwd)/.local/lib:$LD_LIBRARY_PATH PYTHON_FLINT_MINGW64=true' 
        
           export CIBW_BUILD='cp39-* cp310-* cp311-* cp312-*' 
        
           # export CIBW_BUILD='cp311-*' 
        
           export CIBW_SKIP='*-win32 *-manylinux_i686 *-musllinux_*' 
        
           # export CIBW_ARCHS_MACOS="x86_64" 
        
           export CIBW_ARCHS_MACOS="arm64" 
        
           export CIBW_BEFORE_ALL_LINUX=bin/cibw_before_all_linux.sh 
        
           # export CIBW_BEFORE_ALL_MACOS=bin/cibw_before_all_macosx_x86_64.sh 
        
           export CIBW_BEFORE_ALL_MACOS=bin/cibw_before_all_macosx_arm64.sh 
        
           export CIBW_BEFORE_ALL_WINDOWS='C:\\msys64\\usr\\bin\\bash bin/cibw_before_all_windows.sh' 
        
           export CIBW_BEFORE_BUILD='pip install numpy cython delvewheel' 
        
           export CIBW_BEFORE_BUILD_WINDOWS='C:\\msys64\\usr\\bin\\bash bin/cibw_before_build_windows.sh' 
        
           export CIBW_REPAIR_WHEEL_COMMAND_WINDOWS='bin\cibw_repair_wheel_command_windows.bat {dest_dir} {wheel}' 
        
           # export CIBW_TEST_COMMAND="python -c 'import flint; print(str(flint.fmpz(2)))'" 
        
           export CIBW_TEST_COMMAND="python -m flint.test" 
        
           # cibuildwheel --platform linux 
        
           # cibuildwheel --platform windows 
        
           cibuildwheel --platform macos

Thanks Matthias

--no-build-isolation is not needed any more

#111 updates the README accordingly

pyproject.toml: New

a3bacbe

mkoeppe added a commit to passagemath/downstream-pyodide that referenced this pull request Jan 25, 2024

packages/python-flint: Add flintlib/python-flint#108 as a patch

1ed4579

oscarbenjamin merged commit ea65d5f into flintlib:master Jan 25, 2024

mkoeppe deleted the pyproject_toml branch January 25, 2024 18:26

mkoeppe mentioned this pull request Jan 26, 2024

Meta-ticket: Web assembly (wasm) and Pyodide sagemath/sage#34539

Closed

mkoeppe added a commit to passagemath/downstream-pyodide that referenced this pull request Jan 26, 2024

packages/python-flint: Add flintlib/python-flint#108 as a patch

f8bf99b

mkoeppe added a commit to passagemath/downstream-pyodide that referenced this pull request Jan 27, 2024

packages/python-flint: Add flintlib/python-flint#108 as a patch

1e84011

mkoeppe added a commit to passagemath/downstream-pyodide that referenced this pull request Jan 27, 2024

packages/python-flint: Add flintlib/python-flint#108 as a patch

ce360cd

mkoeppe added a commit to passagemath/downstream-pyodide that referenced this pull request Jan 27, 2024

packages/python-flint: Add flintlib/python-flint#108 as a patch

f2216c2

oscarbenjamin mentioned this pull request Feb 1, 2024

Bump version to 0.6.0 #113

Merged

mkoeppe mentioned this pull request Feb 2, 2024

pyproject.toml: Move settings of CIBW_* here #123

Merged

oscarbenjamin mentioned this pull request Mar 25, 2024

Python 3.12, pyproject.toml, distutils and a new build system #52

Closed

Declare build deps in `pyproject.toml` by mkoeppe · Pull Request #108 · flintlib/python-flint · GitHub

Repository navigation

Declare build deps in pyproject.toml - #108

Declare build deps in pyproject.toml#108
oscarbenjamin merged 1 commit into
flintlib:masterfrom
passagemath:pyproject_toml

mkoeppe commented Jan 25, 2024

Uh oh!

oscarbenjamin commented Jan 25, 2024

Uh oh!

oscarbenjamin commented Jan 25, 2024

Uh oh!

mkoeppe commented Jan 25, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Declare build deps in `pyproject.toml` by mkoeppe · Pull Request #108 · flintlib/python-flint · GitHub

Repository navigation

Declare build deps in pyproject.toml - #108

Declare build deps in pyproject.toml#108oscarbenjamin merged 1 commit intoflintlib:masterflintlib/python-flint:masterfrom passagemath:pyproject_tomlpassagemath/upstream-python-flint:pyproject_tomlCopy head branch name to clipboard

Conversation

mkoeppe commented Jan 25, 2024

Uh oh!

oscarbenjamin commented Jan 25, 2024

Uh oh!

oscarbenjamin commented Jan 25, 2024

Uh oh!

mkoeppe commented Jan 25, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Declare build deps in pyproject.toml#108
oscarbenjamin merged 1 commit into
flintlib:masterfrom
passagemath:pyproject_toml