Repository navigation
pyproject.toml: Move settings of CIBW_* here - #123
Merged
oscarbenjamin merged 12 commits intoFeb 2, 2024
Merged
oscarbenjamin merged 12 commits into
oscarbenjamin merged 12 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
mkoeppe
force-pushed
the
cibw_pyproject_toml
branch
from
15dc2b1 to
d8416df
Compare
February 2, 2024 20:17
mkoeppe
force-pushed
the
cibw_pyproject_toml
branch
from
d8416df to
c7f6aaa
Compare
February 2, 2024 20:19
mkoeppe
marked this pull request as ready for review
February 2, 2024 21:14
Copy link
Copy Markdown
Collaborator
|
Looks good. Thanks Matthias! |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As suggested in #108 (comment) @oscarbenjamin
Also increasing build parallelism in CI because GH Actions upgraded to machines with 4 CPUs in late 2023. (https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners/about-github-hosted-runners#standard-github-hosted-runners-for-public-repositories). (make -j6 was a first guess, reducing the wall time of "Build wheels for macos-12" from 28 min to 17 min and "Build wheels for windows-2019" from 28 min to 26 min.)