Repository navigation
Add fmpz_mod_mat - #106
Merged
oscarbenjamin merged 3 commits intoNov 29, 2023
Merged
Add fmpz_mod_mat#106oscarbenjamin merged 3 commits into
oscarbenjamin merged 3 commits into
Conversation
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Author
|
Does anyone want to review this @deinst @GiacomoPope or should I just merge? |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
I had a quick look and it looks good. Nice work with the tests and aligning the other matrix types with this new addition. |
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Author
|
Thanks. Writing the generic test code would be a lot easier if we had a more uniform interface for the different types wrt contexts e.g.: Rs = [fmpz_ctx(), fmpq_ctx(), nmod_ctx(7), fmpz_mod_ctx(7), ...]
for R in Rs:
a = R(2)
p = R.poly([1, 2])
M = R.matrix([[1, 2], [3, 4]])
assert M.charpoly() == R.poly([1, 2, 3])
...
Working on this has made it clear that a uniform interface is worthwhile so I think I will add that soon. |
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Author
|
Okay, let's get this in. |
Sorry, something went wrong.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since fmpz_mod and fmpz_mod_poly were recently added (gh-87 gh-83) this PR adds the corresponding matrix type fmpz_mod_mat.
The tests added are mostly generic tests applied to the 4 exact matrix types fmpz_mat, fmpq_mat, nmod_mat and fmpz_mod_mat. Various methods are added to some of the other types so that they have more consistent interfaces. Also some exception types were changed and some cases where Flint would abort are now handled with Python exceptions (e.g. charpoly on a non-square matrix).
Also nmod_mat now subclasses flint_mat along with the other matrix types and the matrix printing was made more consistent in how ctx.pretty is handled.