Repository navigation
pyproject.toml, setup.py: Only use numpy.distutils on win32 - #112
oscarbenjamin merged 1 commit into
Conversation
Sorry, something went wrong.
|
|
||
|
|
||
| if sys.version_info < (3, 12): | ||
| if sys.platform == 'win32': |
There was a problem hiding this comment.
We need < 3.12 on Windows as well because the numpy.distutils module is removed in Python 3.12. I guess it could be:
if sys.platform == 'win32' and sys.version_info < (3, 12)
Sorry, something went wrong.
There was a problem hiding this comment.
but does the case sys.platform == 'win32' and sys.version_info >= (3, 12) work at all?
Sorry, something went wrong.
There was a problem hiding this comment.
Yes, it works. Every CI job normally passes but the change here has caused the Windows job to fail when building wheels for Python 3.12. These same CI jobs are what build the wheels that go to PyPI which has Windows wheels for Python 3.12:
https://pypi.org/project/python-flint/#files
Some sort of change in CPython itself means that mingw+setuptools works for Python 3.12 but not for Python < 3.12. I don't follow all the details but the clearest explanation I found is here:
cython/cython#4470 (comment)
Sorry, something went wrong.
|
Thanks. I've updated it accordingly |
Sorry, something went wrong.
|
Looks like its working. Thanks Matthias. |
Sorry, something went wrong.
|
The Windows build with cibuildwheel is now failing CI in gh-113. I'm not sure if this or other changes is the cause. |
Sorry, something went wrong.
|
https://github.com/flintlib/python-flint/actions/runs/7748025255/job/21130728629?pr=113#step:5:81 |
Sorry, something went wrong.
|
I don't see why that error should be thrown now and only on Windows. The CI passes after merging this PR: I've just restarted that same CI it to see if it passes again and it has now failed. The cibuildwheel version does not seem to have changed. The msys version does not seem to have changed. The Python versions have not changed. The same argument --only '""' is passed for all other OS but the job only fails on Windows. |
Sorry, something went wrong.
|
Maybe an upstream bug: |
Sorry, something went wrong.
|
I think it is working after bumping the version of cibuildwheel to 2.16.5. Apparently the problem was a change in the GitHub Actions runners that needed an update in the pypa/cibuildwheel action. |
Sorry, something went wrong.
All CI now passed so that looks to be the fix. Thanks for looking at this @mkoeppe |
Sorry, something went wrong.
Using setuptools on all other platforms, as is already done when Python == 3.12 after #100.
Ref #52 (comment) @oscarbenjamin