FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Bump versions and add automatic releases by oscarbenjamin · Pull Request #149 · flintlib/python-flint · GitHub

  1. flintlib
  2. python-flint

Repository navigation

Bump versions and add automatic releases - #149

Merged
oscarbenjamin merged 7 commits into
flintlib:masterfrom
oscarbenjamin:pr_bump_versions
Jul 1, 2024
ConversationCommits (7)ChecksFiles changed
Merged

Bump versions and add automatic releases#149
oscarbenjamin merged 7 commits into
flintlib:masterfrom
oscarbenjamin:pr_bump_versions

Conversation

oscarbenjamin commented Jul 1, 2024

Copy link
Copy Markdown
Collaborator

Work in progress...

edgarcosta commented Jul 1, 2024

Copy link
Copy Markdown
Member

It also might be worth it to go all the way to 3.1.3-p1

oscarbenjamin commented Jul 1, 2024

Copy link
Copy Markdown
Collaborator Author

It also might be worth it to go all the way to 3.1.3-p1

Why is it called 3.1.3-p1?

edgarcosta commented Jul 1, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

I could have called it 3.1.4, and perhaps should have, but the only thing that changed from 3.1.3 was updating the VERSION before bootstrapping, to fix:
Homebrew/homebrew-core#166490 (comment)

oscarbenjamin commented Jul 1, 2024

Copy link
Copy Markdown
Collaborator Author

Ah, okay. The website doesn't have anything past 3.1.2:
https://flintlib.org/downloads.html

edgarcosta commented Jul 1, 2024

Copy link
Copy Markdown
Member

That is indeed true, and someone already created an issue: flintlib/flint#2022

oscarbenjamin commented Jul 1, 2024
View reviewed changes
Comment thread .github/workflows/buildwheel.yml
Comment on lines +159 to +168
# Deploy wheels and sdist to PyPI

pypi_release:
name: Publish to PyPI
needs: [build_wheels, build_sdist]
# Run only when a tag is pushed to the flintlib/python-flint repo
if: "github.event_name == 'push' && startsWith(github.ref, 'refs/tags') && github.owner == 'flintlib'"
environment:
name: pypi
url: https://pypi.org/p/sympy

oscarbenjamin Jul 1, 2024

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Once this is merged I will test pushing a tag to trigger release.

oscarbenjamin Jul 1, 2024

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I might need a few attempts while fixing up the Actions workflow.

I guess it might work first time...

oscarbenjamin merged commit d8c5c84 into flintlib:master Jul 1, 2024
oscarbenjamin deleted the pr_bump_versions branch July 1, 2024 20:22

oscarbenjamin commented Jul 1, 2024

Copy link
Copy Markdown
Collaborator Author

I've just pushed the tag and the workflow is running:
https://github.com/flintlib/python-flint/actions/runs/9750608228

oscarbenjamin commented Jul 1, 2024

Copy link
Copy Markdown
Collaborator Author

(It'll take about 30 minutes to reach the point where I can approve deployment.)

oscarbenjamin commented Jul 1, 2024

Copy link
Copy Markdown
Collaborator Author

Didn't work. Trying again after gh-153:
https://github.com/flintlib/python-flint/actions/runs/9750919090

oscarbenjamin commented Jul 1, 2024

Copy link
Copy Markdown
Collaborator Author

New try: gh-154:
https://github.com/flintlib/python-flint/actions/runs/9751446766

oscarbenjamin commented Jul 1, 2024

Copy link
Copy Markdown
Collaborator Author

Seems to be working so after gh-155 I think it will work:
https://github.com/flintlib/python-flint/actions/runs/9751640936

oscarbenjamin commented Jul 1, 2024
View reviewed changes
Comment thread README.md
- [gh-144](https://github.com/flintlib/python-flint/pull/144)
Add `rel_one_ccuracy_bits` to `arb` and `acb`.
- [gh-142](https://github.com/flintlib/python-flint/pull/142)
Add `acb_theta` (only available for Flint >= 3.1).

oscarbenjamin Jul 1, 2024

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I don't know much about what acb_theta is but I get the impression that it warrants a more significant release note (that someone else would need to write).

oscarbenjamin commented Jul 1, 2024

Copy link
Copy Markdown
Collaborator Author

Okay here you go Edgar:
https://pypi.org/project/python-flint/0.7.0a2/#files

pip install --pre python-flint will give all the acb_theta you want!

oscarbenjamin commented Jul 1, 2024
View reviewed changes
Comment thread .github/workflows/buildwheel.yml
if: "github.event_name == 'push' && startsWith(github.ref, 'refs/tags') && github.owner == 'flintlib'"
environment:
name: pypi
url: https://pypi.org/p/sympy

oscarbenjamin Jul 1, 2024

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Looks I forgot to change the URL when adapting this code...

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL