Repository navigation
gr: Improve conversions - #254
Merged
oscarbenjamin merged 1 commit intoJan 28, 2025
Merged
oscarbenjamin merged 1 commit into
oscarbenjamin merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Comment thread
src/flint/types/_gr.pyx
Comment on lines
+232
to
+242
| if isinstance(arg, gr): | ||
| return self.from_other(arg) | ||
| if arg is int: | ||
| return self.from_si(arg) | ||
| if arg is float: | ||
| return self.from_d(arg) |
Copy link
Copy Markdown
Collaborator
There was a problem hiding this comment.
Should this not be something like if type(arg) is int?
Sorry, something went wrong.
C.f. https://flintlib.org/doc/gr.html#assignment-and-conversions We can use more appropriate functions for conversions than roundtripping through a string
Tom-Hubrecht
force-pushed
the
gr-conversions
branch
from
65ac2cb to
9dfcbf2
Compare
January 28, 2025 15:43
Copy link
Copy Markdown
Collaborator
|
Looks good |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
C.f. https://flintlib.org/doc/gr.html#assignment-and-conversions
We can use more appropriate functions for conversions than roundtripping through a string