Repository navigation
sort factors for all mpoly types - #359
Merged
oscarbenjamin merged 4 commits intoJan 24, 2026
Merged
oscarbenjamin merged 4 commits into
oscarbenjamin merged 4 commits into
Conversation
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Changes in FLINT mean that the factorization of nmod_mpoly and fmpz_mod_mpoly can be returned in different orders. This commit sorts the factors so that they are always returned in the same order.
Copy link
Copy Markdown
Collaborator
Author
|
I think the failed pyodide test is just something that happens randomly sometimes rather than being caused by the changes here. It has failed twice for the last two commits though so we'll just have to see what happens after merging. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes in FLINT mean that the factorization of nmod_mpoly and fmpz_mod_mpoly can be returned in different orders. This commit sorts the factors so that they are always returned in the same order.