Repository navigation
Use MSVC to build python-flint's extension modules - #378
Merged
oscarbenjamin merged 2 commits intoMar 22, 2026
Merged
oscarbenjamin merged 2 commits into
oscarbenjamin merged 2 commits into
Conversation
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Author
The previous gh-377 to use ucrt might improve runtime compatibility since it avoids having two different C runtimes loaded. This PR just means that the extension modules are built with a more standard compiler configuration. That does not necessarily improve compatibility but it may mean that we are less likely to run into untested edge cases that require more complicated build workarounds (thinking of Windows on ARM which we don't address here yet). |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows gh-377
With this PR we still build GMP, MPFR and FLINT on Windows using msys2's ucrt toolchain but we use MSVC to build python-flint's extension modules that link with these. This is hoped to make the extension modules more compatible with standard python.org builds of CPython. Also now though hopefully using MSVC for the extension modules will work better for a future PR adding Windows on ARM (improving on gh-360's approach).