FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Pyodide follow-ups by agriyakhetarpal · Pull Request #403 · flintlib/python-flint · GitHub

Repository navigation

Pyodide follow-ups - #403

Draft
agriyakhetarpal wants to merge 2 commits into
flintlib:mainfrom
agriyakhetarpal:pyodide-follow-ups
Draft

agriyakhetarpal wants to merge 2 commits into
flintlib:mainfrom
agriyakhetarpal:pyodide-follow-ups

Conversation

agriyakhetarpal commented Jun 15, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

xref #394, #401. I bumped to Node.js v24, as that's what we recommend in https://pyodide-build.readthedocs.io/en/latest/tutorials/installation.html#requirements. python-flint doesn't necessarily require it, but v24 is the first to support JSPI.

I have also removed the manual Emscripten toolchain setup, so that we always use the one that cibuildwheel installs via pyodide xbuildenv install-emscripten and we have the correct toolchain on PATH. Let's see if that works.

Copy link
Copy Markdown
Contributor Author

Ah, right, @oscarbenjamin I remember that the cibuildwheel Emscripten installation happens a little later in the process and not at the time of before-all. I think we are good for you to release with #401 as such, but I should explore if there is a chance we can install Emscripten in cibuildwheel at an earlier stage.

However, there is still one way which we could take because we only build for one Pyodide version/ABI (314.0.0, hence the 2026 ABI), which would be that we move the WASM compilation of the libs to before-build, instead of before-all, as that occurs after Emscripten is installed. But before I do that, I think I should ask whether you plan to support only one ABI at a time? The 2027 ABI will arrive next year, and packaging tools will be updated accordingly, but I know other packages are being built for both the 2025 and 2026 ABIs to push to PyPI.

Copy link
Copy Markdown
Collaborator

But before I do that, I think I should ask whether you plan to support only one ABI at a time?

Exactly. I don't know what the plan would be in future but I imagine there would be reasons to support at least two pyodide versions simultaneously. Then for the build it is better if before-all builds the libs once to be reused in both wheels if possible.

Copy link
Copy Markdown
Collaborator

I imagine there would be reasons to support at least two pyodide versions simultaneously.

That being said I would definitely be happy to go with the lowest maintenance option right now and not consider anything else until the need arises in future. Currently we support zero pyodide versions so we can start by supporting one and then see where that lands us in future.

This branch has not been deployed

No deployments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL