Add account switcher to system tray context menu - #1659
Open
0xqiba wants to merge 6 commits into
Open
0xqiba wants to merge 6 commits into
0xqiba wants to merge 6 commits into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
* start migrating types to use zod for parsing and defaults * finish basic state loading, add some tests * use current base state when state is corrupted * fix tests * fix gas for tests * update legacy migrations to be more resilient * add test migration files * update migration 38 * update tests * continue updating schemas * add dapp schema * add more types * initial working version * fix some tests * finish tokens schema * finish updating migrations * add settings for panel and selected * update most of state not to persist * allow chain metadata with no native currency rate data * update types to support migration from v0.4.4 * fix typo * add last migration test * fix test * dont persist signers * update test * fix test * final changes * update version * remove no check and add any to legacy migrations * skip test * cleanup
* allow context menu to update itself using injected properties * update account list when accounts change * remove old code referencing main.shortcuts.altSlash
mholtzman
force-pushed
the
canary
branch
2 times, most recently
from
e042db7 to
066b9a9
Compare
March 12, 2024 16:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds an Accounts submenu to the system tray menu for switching between accounts without having to bring up the main Frame window. It also now shows the keyboard shortcut, if enabled, next to the Summon/Dismiss menu item.
As part of this change, I removed some multiple display handling code (switchScreen in systemTray.ts). In my testing, it didn't seem to have any effect, but please let me know if I'm mistaken.
Happy to iterate on any feedback you may have. Thanks!