Suppress UnassignedGetOnlyAutoProperty for Node.GetHashCode - #3138
Merged
jnyrup merged 1 commit intoDec 18, 2025
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
The analyzer is correct that `GetHashCode()` shouldn't use mutable members. See https://www.jetbrains.com/help/rider/NonReadonlyMemberInGetHashCode.html for more details. For `Node` however, we only use `GetHashCode()` when calling `Union()` in `AllPropertiesSelectionRule` and `AllFieldsSelectionRule`. So we should be safe.
Copy link
Copy Markdown
Qodana for .NETIt seems all right 👌 No new problems were found according to the checks applied 💡 Qodana analysis was run in the pull request mode: only the changed files were checked Contact us at qodana-support@jetbrains.com
|
Sorry, something went wrong.
dennisdoomen
approved these changes
Dec 18, 2025
jnyrup
added a commit
to jnyrup/fluentassertions
that referenced
this pull request
Dec 18, 2025
I used the wrong suppression in fluentassertions#3138
jnyrup
added a commit
that referenced
this pull request
Dec 18, 2025
I used the wrong suppression in #3138
This was referenced Mar 16, 2026
Merged
This was referenced Aug 24, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The analyzer is correct that GetHashCode() shouldn't use mutable members. See https://www.jetbrains.com/help/rider/NonReadonlyMemberInGetHashCode.html for more details.
For Node however, we only use GetHashCode() when calling Union() in AllPropertiesSelectionRule and AllFieldsSelectionRule. So we should be safe.
IMPORTANT
CONTRIBUTOR LICENSE GRANT
By submitting this contribution, the contributor hereby irrevocably grants to the project owners and maintainers a perpetual, worldwide, royalty-free, irrevocable license to use, reproduce, modify, distribute, sublicense, and create derivative works of the contribution for any purpose and under any terms, including proprietary licensing.
The contributor waives any moral rights in the contribution to the extent permitted by law and agrees not to assert any claim of authorship or control over the contribution. The contributor represents that they are the sole author of the contribution and that it is provided free of any third-party claims.
The contributor understands and agrees that the maintainers may, at their sole discretion, use, license, or redistribute the contribution as part of any work and under any terms they choose, without further permission or attribution.