Improve reporting the subject when chaining Throw and Which - #3160
Merged
dennisdoomen merged 1 commit intoFeb 21, 2026
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
dennisdoomen
force-pushed
the
fix/871-exception-chaining
branch
from
0f6e84c to
63d0829
Compare
February 21, 2026 21:16
Copy link
Copy Markdown
Qodana for .NETIt seems all right 👌 No new problems were found according to the checks applied 💡 Qodana analysis was run in the pull request mode: only the changed files were checked Contact us at qodana-support@jetbrains.com
|
Sorry, something went wrong.
This was referenced Mar 16, 2026
Merged
This was referenced Aug 23, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit improves caller/subject identification for chained assertions, especially in exception assertions, by allowing the chain to prepend a custom prefix to the generated caller identifier.
throwingAction.Should().Throw<SomeException>().Which.Property.Should().Be("Value");
will now report
Expected SomeException.Property to be a match with the expectation, but it differs at index 0:
Notice the name of the exception type.
Closes #871