FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Add ComparingNullCollectionsAsEmpty and ComparingNullStringsAsEmpty options to BeEquivalentTo by dennisdoomen · Pull Request #3202 · fluentassertions/fluentassertions · GitHub

/ fluentassertions Public

Add ComparingNullCollectionsAsEmpty and ComparingNullStringsAsEmpty options to BeEquivalentTo - #3202

Merged
dennisdoomen merged 1 commit into
mainfrom
dennisdoomen/be-equivalent-to-null-or-empty
May 6, 2026
ConversationCommits (1)ChecksFiles changed
Merged

Add ComparingNullCollectionsAsEmpty and ComparingNullStringsAsEmpty options to BeEquivalentTo#3202
dennisdoomen merged 1 commit into
mainfrom
dennisdoomen/be-equivalent-to-null-or-empty

Conversation

dennisdoomen commented May 3, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Closes #1938

Summary

Adds two new equivalency options to treat null as equivalent to empty in BeEquivalentTo comparisons:

  • ComparingNullCollectionsAsEmpty() — treats a null collection (subject or expectation) as equivalent to an empty collection
  • ComparingNullStringsAsEmpty() — treats a null string (subject or expectation) as equivalent to an empty string ""

Both options follow the existing gerund naming pattern (ComparingEnumsByName, ComparingRecordsByValue, etc.) and work symmetrically (either side may be null).

Usage

// Collections
((int[])null).Should().BeEquivalentTo([], opt => opt.ComparingNullCollectionsAsEmpty());
Array.Empty<int>().Should().BeEquivalentTo(null, opt => opt.ComparingNullCollectionsAsEmpty());

// Strings
((string)null).Should().BeEquivalentTo("", opt => opt.ComparingNullStringsAsEmpty());
"".Should().BeEquivalentTo(null, opt => opt.ComparingNullStringsAsEmpty());

// Nested in an object graph
var subject = new { Items = (int[])null, Name = (string)null };
var expected = new { Items = Array.Empty<int>(), Name = "" };
subject.Should().BeEquivalentTo(expected, opt => opt
    .ComparingNullCollectionsAsEmpty()
    .ComparingNullStringsAsEmpty());

github-actions Bot commented May 3, 2026 •
edited
Loading

Copy link
Copy Markdown

Test Results

    37 files  ±  0      37 suites  ±0   2m 33s ⏱️ -9s
 6 383 tests + 20   6 382 ✅ + 20  1 💤 ±0  0 ❌ ±0 
39 644 runs  +120  39 638 ✅ +120  6 💤 ±0  0 ❌ ±0 

Results for commit 44067f3. ± Comparison against base commit 84b7cb6.

This pull request removes 10 and adds 28 tests. Note that renamed tests count towards both. 
FluentAssertions.Specs.Streams.StreamAssertionSpecs+HaveLength ‑ When_a_throwing_stream_should_have_a_length_it_should_fail(exception: System.ObjectDisposedException: Cannot access a disposed object.
FluentAssertions.Specs.Streams.StreamAssertionSpecs+HaveLength ‑ When_a_throwing_stream_should_have_a_length_it_should_fail(exception: System.ObjectDisposedException: Cannot access a disposed object.
FluentAssertions.Specs.Streams.StreamAssertionSpecs+HavePosition ‑ When_a_throwing_stream_should_have_a_position_it_should_fail(exception: System.ObjectDisposedException: Cannot access a disposed object.
FluentAssertions.Specs.Streams.StreamAssertionSpecs+HavePosition ‑ When_a_throwing_stream_should_have_a_position_it_should_fail(exception: System.ObjectDisposedException: Cannot access a disposed object.
FluentAssertions.Specs.Streams.StreamAssertionSpecs+NotHaveLength ‑ When_a_throwing_stream_should_not_have_a_length_it_should_fail(exception: System.ObjectDisposedException: Cannot access a disposed object.
FluentAssertions.Specs.Streams.StreamAssertionSpecs+NotHaveLength ‑ When_a_throwing_stream_should_not_have_a_length_it_should_fail(exception: System.ObjectDisposedException: Cannot access a disposed object.
FluentAssertions.Specs.Streams.StreamAssertionSpecs+NotHavePosition ‑ When_a_throwing_stream_should_not_have_a_position_it_should_fail(exception: System.ObjectDisposedException: Cannot access a disposed object.
FluentAssertions.Specs.Streams.StreamAssertionSpecs+NotHavePosition ‑ When_a_throwing_stream_should_not_have_a_position_it_should_fail(exception: System.ObjectDisposedException: Cannot access a disposed object.
Object name: 'GetLengthExceptionMessage'.)
Object name: 'GetPositionExceptionMessage'.)

FluentAssertions.Equivalency.Specs.CollectionSpecs+ComparingNullCollectionsAsEmpty ‑ A_non_empty_subject_collection_fails_when_the_expectation_is_null
FluentAssertions.Equivalency.Specs.CollectionSpecs+ComparingNullCollectionsAsEmpty ‑ A_null_generic_list_subject_is_equivalent_to_an_empty_generic_list_expectation
FluentAssertions.Equivalency.Specs.CollectionSpecs+ComparingNullCollectionsAsEmpty ‑ A_null_nested_collection_is_equivalent_to_an_empty_nested_collection
FluentAssertions.Equivalency.Specs.CollectionSpecs+ComparingNullCollectionsAsEmpty ‑ A_null_subject_collection_fails_when_the_expectation_is_non_empty
FluentAssertions.Equivalency.Specs.CollectionSpecs+ComparingNullCollectionsAsEmpty ‑ A_null_subject_collection_is_equivalent_to_an_empty_expectation
FluentAssertions.Equivalency.Specs.CollectionSpecs+ComparingNullCollectionsAsEmpty ‑ An_empty_generic_list_subject_is_equivalent_to_a_null_generic_list_expectation
FluentAssertions.Equivalency.Specs.CollectionSpecs+ComparingNullCollectionsAsEmpty ‑ An_empty_nested_collection_is_equivalent_to_a_null_nested_collection
FluentAssertions.Equivalency.Specs.CollectionSpecs+ComparingNullCollectionsAsEmpty ‑ An_empty_subject_collection_is_equivalent_to_a_null_expectation
FluentAssertions.Equivalency.Specs.CollectionSpecs+ComparingNullCollectionsAsEmpty ‑ Two_null_collections_are_equivalent
FluentAssertions.Equivalency.Specs.CollectionSpecs+ComparingNullCollectionsAsEmpty ‑ Without_the_option_a_null_subject_collection_is_not_equivalent_to_an_empty_expectation
…

♻️ This comment has been updated with latest results.

coveralls commented May 3, 2026 •
edited
Loading

Copy link
Copy Markdown

Coverage Report for CI Build 25275762917

Coverage decreased (-0.03%) to 97.142%

Details

  • Coverage decreased (-0.03%) from the base build.
  • Patch coverage: 35 of 35 lines across 6 files are fully covered (100%).
  • No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.

Coverage Stats
Relevant Lines: 13394
Covered Lines: 13169
Line Coverage: 98.32%
Relevant Branches: 4382
Covered Branches: 4099
Branch Coverage: 93.54%
Branches in Coverage %: Yes
Coverage Strength: 78677.89 hits per line
💛 - Coveralls

github-actions Bot commented May 3, 2026 •
edited
Loading

Copy link
Copy Markdown

Qodana for .NET

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

dennisdoomen marked this pull request as draft May 3, 2026 09:20
dennisdoomen marked this pull request as ready for review May 3, 2026 09:31
dennisdoomen requested review from Copilot and jnyrup May 3, 2026 09:31
dennisdoomen force-pushed the dennisdoomen/be-equivalent-to-null-or-empty branch from 3fd5e9a to 6cf7fb6 Compare May 3, 2026 09:42
Add ComparingNullCollectionsAsEmpty and ComparingNullStringsAsEmpty o…
44067f3 
…ptions to BeEquivalentTo

Fixes #1938 by introducing two new equivalency options:
- ComparingNullCollectionsAsEmpty(): treats null collections as equivalent to empty ones
- ComparingNullStringsAsEmpty(): treats null strings as equivalent to empty strings

Both options work for direct assertions and when the subject is nested inside an object graph.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
dennisdoomen force-pushed the dennisdoomen/be-equivalent-to-null-or-empty branch from 6cf7fb6 to 44067f3 Compare May 3, 2026 09:43
dennisdoomen removed the request for review from Copilot May 3, 2026 09:43
dennisdoomen merged commit fb42954 into main May 6, 2026
14 checks passed
dennisdoomen deleted the dennisdoomen/be-equivalent-to-null-or-empty branch May 6, 2026 05:15
This was referenced May 12, 2026
Merged
Merged
Merged
Merged
Closed
Merged
Merged
Closed
Closed
Closed
Merged
Open
searledan added a commit to fiscaltec/vitally-mcp that referenced this pull request May 12, 2026
build: bump FluentAssertions from 8.9.0 to 8.10.0 (#10)
096143a 
Updated
[FluentAssertions](https://github.com/fluentassertions/fluentassertions)
from 8.9.0 to 8.10.0.

<details>
<summary>Release notes</summary>

_Sourced from [FluentAssertions's
releases](https://github.com/fluentassertions/fluentassertions/releases)._

## 8.10.0

<!-- Release notes generated using configuration in .github/release.yml
at main -->

## What's Changed
### Improvements
* Fail with a descriptive error when path-based rules are used on
value-semantic types by @​dennisdoomen in
fluentassertions/fluentassertions#3187
* Significantly speed up BeEquivalentTo for large unordered collections
by @​dennisdoomen in
fluentassertions/fluentassertions#3188
* Add ComparingNullCollectionsAsEmpty and ComparingNullStringsAsEmpty
options to BeEquivalentTo by @​dennisdoomen in
fluentassertions/fluentassertions#3202
* Include original index in extraneous item failure messages by
@​dennisdoomen in
fluentassertions/fluentassertions#3203
### Documentation
* Reroute the docs link to Xceed by @​dennisdoomen in
fluentassertions/fluentassertions#3183
* Fix typo in release notes by @​jnyrup in
fluentassertions/fluentassertions#3194
* Fix typos in docs by @​jnyrup in
fluentassertions/fluentassertions#3197
### Others
* Bump flatted from 3.4.1 to 3.4.2 in the npm_and_yarn group across 1
directory by @​dependabot[bot] in
fluentassertions/fluentassertions#3184
* Add AI assistant instruction file (agents.md) for Copilot, Claude, and
JetBrains Junie by @​Copilot in
fluentassertions/fluentassertions#3176
* Bump smol-toml from 1.6.0 to 1.6.1 in the npm_and_yarn group across 1
directory by @​dependabot[bot] in
fluentassertions/fluentassertions#3185
* Bump the npm_and_yarn group across 1 directory with 2 updates by
@​dependabot[bot] in
fluentassertions/fluentassertions#3186
* Bump cspell from 9.7.0 to 10.0.0 by @​dependabot[bot] in
fluentassertions/fluentassertions#3189
* Update nugets by @​jnyrup in
fluentassertions/fluentassertions#3192
* Fixup Qodana issues by @​jnyrup in
fluentassertions/fluentassertions#3193
* Fix Qodana argument separator by @​jnyrup in
fluentassertions/fluentassertions#3195
* Use new Qodana linter option by @​jnyrup in
fluentassertions/fluentassertions#3196
* Fix flaky BeLessThanOrEqualTo execution time test by @​Copilot in
fluentassertions/fluentassertions#3200
* Bump JetBrains/qodana-action from 2025.3 to 2026.1 by
@​dependabot[bot] in
fluentassertions/fluentassertions#3201
* Use long for hashCode in ReferentialComparer to avoid overflow by
@​dennisdoomen in
fluentassertions/fluentassertions#3204


**Full Changelog**:
fluentassertions/fluentassertions@8.9.0...8.10.0

Commits viewable in [compare
view](fluentassertions/fluentassertions@8.9.0...8.10.0).
</details>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Dan Searle <dan_searle@outlook.com>
dependabot Bot mentioned this pull request May 12, 2026
Merged
This was referenced Aug 24, 2026
Open
Open
Open
Closed
Closed
Closed
Closed
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Closed
Open
Open
Open
Open
Open
Open
Closed
Open
Open
Open
Merged
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jnyrup jnyrup approved these changes

Assignees

No one assigned

Labels

enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

BeEquivalentTo needs option like BeNullOrEmpty [Enhancement]

3 participants

Back | FazBrowse Home | New Git URL