| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
There was a problem hiding this comment.
This pull request updates SearchAnchor to prevent stale asynchronous suggestions from overwriting newer results. It introduces an internal counter, _suggestionsCallId, to track suggestion requests and discard results from outdated calls. A new test case has been added to verify that out-of-order asynchronous suggestions are ignored. No review comments were provided, and there is no feedback to provide.
Sorry, something went wrong.
There was a problem hiding this comment.
LGTM since this PR is ported over from flutter/flutter:) Could you also make sure all items in "Pre-Review Checklist" are checked?
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
Ports flutter/flutter#190206 to material_ui following flutter/flutter#188444.
Fixes flutter/flutter#190205.
This change prevents an older asynchronous SearchAnchor.suggestionsBuilder request from replacing the results of a newer request.
It assigns an incrementing ID to each suggestions request and only applies the result when it still represents the latest request.
Pre-Review Checklist
If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.
Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2