FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

New unsigned datatypes, Removed std::to_string by ElephantInTheRoomFirst · Pull Request #15 · fnc12/sqlite_orm · GitHub

/ sqlite_orm Public

New unsigned datatypes, Removed std::to_string - #15

Merged
fnc12 merged 1 commit into
fnc12:masterfrom
ElephantInTheRoomFirst:master
May 25, 2017
ConversationCommits (1)ChecksFiles changed
Merged

New unsigned datatypes, Removed std::to_string#15
fnc12 merged 1 commit into
fnc12:masterfrom
ElephantInTheRoomFirst:master

Conversation

ElephantInTheRoomFirst commented May 25, 2017

Copy link
Copy Markdown
Contributor

Removed std::to_string usage
Added unsigned char
Added signed char
Added unsigned short int
Added unsigned int
Removed const return types to avoid complier warnings

New unsigned datatypes, Removed std::to_string
2d336c6 
Removed std::to_string usage
Added unsigned char
Added signed char
Added unsigned short int
Added unsigned int

fnc12 commented May 25, 2017 •
edited
Loading

Copy link
Copy Markdown
Owner

why did you remove const from const bool operator==(const iterator_t &other) const? It is recommended to add const to make statements like this (it1 == it2) = it3; unavailable

ElephantInTheRoomFirst commented May 25, 2017

Copy link
Copy Markdown
Contributor Author

I was getting complier warning.

sqlite_orm.h:2651: warning: type qualifiers ignored on function return type [-Wignored-qualifiers]
const bool operator==(const iterator_t &other) const {

gcc (GCC) 6.2.1 20160916 (Red Hat 6.2.1-3)

fnc12 commented May 25, 2017

Copy link
Copy Markdown
Owner

Ok. Thanks you very much. I accept your pull request and remove couts at all in the next commit.

fnc12 merged commit 69cce51 into fnc12:master May 25, 2017

ElephantInTheRoomFirst commented May 25, 2017

Copy link
Copy Markdown
Contributor Author

Thanks. :)

fnc12 added a commit that referenced this pull request Jan 31, 2023
Merge pull request #15 from fnc12/feature/dynamic-set
81f828c 
added dynamic_set
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL