FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Cut release 3.17.12 by nficca · Pull Request #1727 · fossas/fossa-cli · GitHub

/ fossa-cli Public

Cut release 3.17.12 - #1727

Merged
nficca merged 3 commits into
masterfrom
cut-release-for-themis-1.0.57
Jul 1, 2026
ConversationCommits (3)ChecksFiles changed
Merged

Cut release 3.17.12#1727
nficca merged 3 commits into
masterfrom
cut-release-for-themis-1.0.57

Conversation

nficca commented Jun 30, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Overview

Cuts release for 3.17.12. Should pull in the latest themis.

Acceptance criteria

If this PR is successful, what impact does it have on the user experience?

Example: When users do X, Y should now happen.

Testing plan

How did you validate that this PR works? What literal steps did you take when manually checking that your code works?

Example:

  1. Set up test case X.
  2. Run command Y. Make sure Z happens.

This section should list concrete steps that a reviewer can sanity check and repeat on their own machine (and provide any needed test cases).

Risks

Highlight any areas that you're unsure of, want feedback on, or want reviewers to pay particular attention to.

Example: I'm not sure I did X correctly, can reviewers please double-check that for me?

Metrics

Is this change something that can or should be tracked? If so, can we do it today? And how? If its easy, do it

References

Add links to any referenced GitHub issues, Zendesk tickets, Jira tickets, Slack threads, etc.

Example:

Checklist

  • I added tests for this PR's change (or explained in the PR description why tests don't make sense).
  • If this PR introduced a user-visible change, I added documentation into docs/.
  • If this PR added docs, I added links as appropriate to the user manual's ToC in docs/README.ms and gave consideration to how discoverable or not my documentation is.
  • If this change is externally visible, I updated Changelog.md. If this PR did not mark a release, I added my changes into an ## Unreleased section at the top.
  • If I made changes to .fossa.yml or fossa-deps.{json.yml}, I updated docs/references/files/*.schema.json AND I have updated example files used by fossa init command. You may also need to update these if you have added/removed new dependency type (e.g. pip) or analysis target type (e.g. poetry).
  • If I made changes to a subcommand's options, I updated docs/references/subcommands/<subcommand>.md.

nficca marked this pull request as ready for review June 30, 2026 21:09
nficca requested a review from a team as a code owner June 30, 2026 21:09
nficca requested a review from csasarak June 30, 2026 21:09

coderabbitai Bot commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

Walkthrough

This change updates the Changelog.md file, replacing the "Unreleased" placeholder section header with a new "3.17.12" release section. A new bullet point was added under this section documenting the addition of FSL 1.1 license variants. The change consists of a single line modification plus one new line, with no code or public API alterations.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description includes an overview, but the required template sections are still mostly placeholders and not substantively filled out. Add concrete content for acceptance criteria, testing plan, risks, metrics, and references, and complete the checklist items instead of leaving template text.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the release cut for version 3.17.12.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

coderabbitai Bot reviewed Jun 30, 2026
View reviewed changes

coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@Changelog.md`:
- Line 5: The changelog entry has a punctuation typo in the “Licensing” bullet:
the text in Changelog.md includes an extra period after “FSL 1.1.”. Update that
entry to use the same wording without the extra period so it reads consistently
as “FSL 1.1 license variants,” keeping the rest of the bullet unchanged.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes
ℹ️ Review info ⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: ASSERTIVE

Plan: Pro

Run ID: c7e23f08-1cc3-4853-bf9a-a828b5ebe3e0

📥 Commits

Reviewing files that changed from the base of the PR and between b5a1c53 and 90e5e3f.

📒 Files selected for processing (1)
  • Changelog.md

Comment thread Changelog.md Outdated
nficca enabled auto-merge (squash) June 30, 2026 21:15
nficca merged commit f9cd35f into master Jul 1, 2026
19 of 20 checks passed
nficca deleted the cut-release-for-themis-1.0.57 branch July 1, 2026 02:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

coderabbitai[bot] coderabbitai[bot] left review comments
csasarak csasarak approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL