Feature/prettier cflint - #1649
Open
psarin wants to merge 3 commits into
Open
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
Update .gitignore to match recs from www.gitignore.io
Copy link
Copy Markdown
Member
|
Thanks for starting this - for using prettier on the json files I think it is a good idea, can you confirm that the rules you have created are best matching for the format we currently have? |
Sorry, something went wrong.
Copy link
Copy Markdown
|
@pfreitag best matching seems like an impossible task, the JSON files don't currently seem to follow any kind of consistent style, but I do think whats provided here is the best you're going to get as far as things like use of tabs, double quotes, etc |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding prettier and cflint rules as per #1027. Upon agreement of rules, will refort JSON and other files based on rules.