FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Load `UNSPECIFIED` as `0` in `metric_config_bounds` keys by llucax · Pull Request #224 · frequenz-floss/frequenz-client-common-python · GitHub

Repository navigation

Load UNSPECIFIED as 0 in metric_config_bounds keys - #224

Merged
llucax merged 2 commits into
frequenz-floss:v0.x.xfrom
llucax:no-unspecified-bounds-0
Jun 30, 2026
Merged

llucax merged 2 commits into
frequenz-floss:v0.x.xfrom
llucax:no-unspecified-bounds-0

Conversation

llucax commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

This is to be consistent with how other deprecated UNSPECIFIED values are stored internally.

Part of #223.

llucax requested a review from a team as a code owner June 26, 2026 14:18
llucax requested review from shsms and removed request for a team June 26, 2026 14:18
github-actions Bot added part:tests Affects the unit, integration and performance (benchmarks) tests part:microgrid Affects the microgrid protobuf definitions part:docs Affects the documentation labels Jun 26, 2026
llucax self-assigned this Jun 26, 2026
llucax enabled auto-merge June 26, 2026 14:32
llucax added this to the v0.4.1 milestone Jun 26, 2026
llucax added the type:enhancement New feature or enhancement visitble to users label Jun 26, 2026
llucax added 2 commits June 29, 2026 17:25
This is to be consistent with how other deprecated `UNSPECIFIED` values
are stored internally.

Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
This release note should have been added by frequenz-floss#220.

Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
llucax force-pushed the no-unspecified-bounds-0 branch from 0b9982b to 50700de Compare June 29, 2026 15:25

llucax commented Jun 29, 2026

Copy link
Copy Markdown
Contributor Author

Rebased.

florian-wagner-frequenz left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

llucax added this pull request to the merge queue Jun 30, 2026
Merged via the queue into frequenz-floss:v0.x.x with commit b19ab7f Jun 30, 2026
9 checks passed
llucax deleted the no-unspecified-bounds-0 branch June 30, 2026 08:21
llucax added a commit to llucax/frequenz-client-common-python that referenced this pull request Sep 16, 2026
* Mention that `metric_config_bounds` keys also store the raw `0` for
  unspecified metrics (frequenz-floss#224).
* Merge the two `Microgrid` bullets, which described the same addition.
* Describe the `ElectricalComponent` boolean accessors (frequenz-floss#237), the
  `CategorySpecificInfo` field (frequenz-floss#257, frequenz-floss#273) and the aggregated
  `metric_config_bounds` (frequenz-floss#268).
* Add a compact list of the smaller supporting types from frequenz-floss#248 and
  frequenz-floss#249 (`Invalid{Latitude,Longitude,CountryCode}`, `InvalidLifetime`
  and their errors).

Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
llucax added a commit to llucax/frequenz-client-common-python that referenced this pull request Sep 16, 2026
Fill the gaps found in a pre-release sanity check of `RELEASE_NOTES.md`:

* Replace the template placeholder with a real release summary,
including release stats and the note that this is a huge release despite
the patch version, realizing the new library design while keeping
backwards compatibility, with the breaking cleanup to follow in v0.5.0.
* Document two breaking changes to symbols released in v0.4.0 that were
missing from Upgrading: `Bounds` raising on `NaN` endpoints (frequenz-floss#254) and
`MetricConnection.name` no longer being optional (frequenz-floss#257).
* Complete the `UNSPECIFIED`-as-`0` bullet with `metric_config_bounds`
keys (frequenz-floss#224), merge the duplicated `Microgrid` bullets, and briefly cover
the `ElectricalComponent` accessors, `CategorySpecificInfo` and the
smaller `Invalid*` types from frequenz-floss#237, frequenz-floss#248, frequenz-floss#249, frequenz-floss#257, frequenz-floss#268 and frequenz-floss#273.
* Add the `str()` exception message change (frequenz-floss#258) to Bug Fixes.

The `PaginationInfo` breaking change from frequenz-floss#217 is documented separately
in frequenz-floss#285, which adds `InvalidPaginationInfo` and
`pagination_info_from_proto2`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

part:docs Affects the documentation part:microgrid Affects the microgrid protobuf definitions part:tests Affects the unit, integration and performance (benchmarks) tests type:enhancement New feature or enhancement visitble to users

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL