Pull request overview

This PR updates frequenz-client-common’s public surface to be explicit about Python’s PEP 484 numeric-tower behavior by introducing a FloatInt = float | int alias and propagating it through affected dataclasses and accessors, preventing “looks exhaustive” runtime logic (e.g. match … case float():) from silently falling through on int values.

Changes:

• Add FloatInt type alias and update relevant float-annotated fields/accessors to use it (e.g. metrics samples, bounds, location, transformer voltages).
• Rework bounds handling to preserve malformed wire data (InvalidBounds, InvalidBoundsSet) and add normalization/membership semantics (BoundsSet) plus new semantic accessors (MetricSample.get_bounds_set(), ElectricalComponent.get_metric_config_bounds()).
• Deprecate older proto conversion helpers (bounds_from_proto, bounds_from_proto_with_issues) in favor of bounds_from_proto2.

Reviewed changes

Copilot reviewed 36 out of 36 changed files in this pull request and generated 3 comments.

src/frequenz/client/common/metrics/_bounds.py:70

• Bounds.__contains__ treats NaN items as not contained, but Bounds.__post_init__ currently allows NaN in lower/upper. With NaN bounds, comparisons become non-total (e.g. item < nan is False), which can make containment checks accept values they shouldn’t and can also break sorting/merging in BoundsSet. Consider rejecting NaN bounds at construction time.

    def __post_init__(self) -> None:
        """Validate these bounds."""
        if self.lower is None:
            return
        if self.upper is None:
            return
        if self.lower > self.upper:
            raise ValueError(
                f"Lower bound ({self.lower}) must be less than or equal to upper "
                f"bound ({self.upper})"
            )

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Pull request overview

Copilot reviewed 36 out of 36 changed files in this pull request and generated 2 comments.

src/frequenz/client/common/metrics/_bounds.py:66

• Bounds.__contains__() (and BoundsSet normalization) assumes lower/upper are ordered values. If either bound is NaN, the comparisons are non-transitive (x < nan and x > nan are both False), so membership tests can incorrectly return True for arbitrary values (e.g. 0 in Bounds(lower=math.nan, upper=10.0) would be True). Consider rejecting NaN bounds in __post_init__ so malformed wire data is surfaced as InvalidBounds via bounds_from_proto2.

    def __post_init__(self) -> None:
        """Validate these bounds."""
        if self.lower is None:
            return
        if self.upper is None:
            return
        if self.lower > self.upper:

python troubles.