Repository navigation
Remove methods that were moved to client repo - #82
Merged
Marenz merged 8 commits intoDec 4, 2024
Merged
Marenz merged 8 commits into
Marenz merged 8 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Marenz
marked this pull request as draft
December 2, 2024 14:22
Marenz
force-pushed
the
remclean
branch
2 times, most recently
from
2d28695 to
6782f52
Compare
December 3, 2024 17:31
Marenz
marked this pull request as ready for review
December 3, 2024 17:34
* The `running` property was renamed to `started` * The running state was removed Signed-off-by: Mathias L. Baumann <mathias.baumann@frequenz.com>
The modules were moved to client-dispatch Signed-off-by: Mathias L. Baumann <mathias.baumann@frequenz.com>
Signed-off-by: Mathias L. Baumann <mathias.baumann@frequenz.com>
Signed-off-by: Mathias L. Baumann <mathias.baumann@frequenz.com>
This makes the code cleaner. Signed-off-by: Mathias L. Baumann <mathias.baumann@frequenz.com>
llucax
previously approved these changes
Dec 4, 2024
llucax
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Bye bye RunningState.DIFFERENT_TYPE, you will not be missed 🤣 ❤️
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
I missed it already, tbh. Now you have to make double-sure you check for the .type before looking at running. Already missed one occasion for that before that I luckily found later. Still not convinced this is a better interface that leads to less errors. |
Sorry, something went wrong.
Marenz
added this pull request to the merge queue
Dec 4, 2024
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Dec 4, 2024
Marenz
added this pull request to the merge queue
Dec 4, 2024
Copy link
Copy Markdown
Contributor
Author
|
Maybe the receiver should come pre-filtered for a set of types you specify 🤔 |
Sorry, something went wrong.
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Dec 4, 2024
Marenz
added this pull request to the merge queue
Dec 4, 2024
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Dec 4, 2024
Marenz
added this pull request to the merge queue
Dec 4, 2024
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Dec 4, 2024
Marenz
added this pull request to the merge queue
Dec 4, 2024
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Dec 4, 2024
Marenz
enabled auto-merge
December 4, 2024 17:33
Signed-off-by: Mathias L. Baumann <mathias.baumann@frequenz.com>
Signed-off-by: Mathias L. Baumann <mathias.baumann@frequenz.com>
Signed-off-by: Mathias L. Baumann <mathias.baumann@frequenz.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR looks large, but most commits are just small changes. Tried to keep it well separated.