feat(chat): update chat.getMessages tool to support filtering by thread name - #110
allenhutchison merged 2 commits into
Conversation
Sorry, something went wrong.
- Introduces a new optional param `threadName` to the tool description for `chat.getMessages` with a description including a sample thread name. - Updates the `ChatService.getMessages` function to include a threadName param. If defined, the threadname is included in the "filter" param for the Chat API request. - Added unit tests
Summary of ChangesHello @kamladi, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the chat.getMessages tool by introducing the capability to filter messages by a specific thread name. Previously, the tool could only fetch messages across an entire space, limiting its utility for targeted requests. With this change, users can now accurately query and summarize messages within a particular thread, improving the tool's precision and responsiveness to more complex prompts. The update involves modifications to the tool's input schema, the ChatService logic for constructing API requests, and comprehensive unit tests to ensure correct functionality. Highlights
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here. Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
Sorry, something went wrong.
There was a problem hiding this comment.
Code Review
This pull request adds support for filtering messages by thread name in the chat.getMessages tool. The changes are well-implemented, including updates to the service layer to build the filter query, modifications to the tool definition, and new unit tests to cover the functionality. The approach of using a filters array is scalable for future additions. I have one suggestion to improve code maintainability.
Sorry, something went wrong.
allenhutchison
left a comment
There was a problem hiding this comment.
This looks great, thank you for the contribution!
Sorry, something went wrong.
Example prompt: summarize the messages in the thread linked in https://chat.google.com/room/{spaceId}/{threadId}/{messageId}
Previously, this prompt would result in a failure, as the tool could only paginate across all messages in the space, and was not able to filter by a thread ID. This change allows this type of prompt to succeed, as the tool can now include a threadID filter in the Chat API request.