chore: add prettier to CI and project configuration - #182
allenhutchison merged 9 commits into
Conversation
Sorry, something went wrong.
Summary of ChangesHello @raybell-md, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request integrates Prettier into the project to enforce consistent code styling across the codebase. It sets up the necessary configuration files, adds Prettier as a development dependency, and provides convenient npm scripts for checking and automatically fixing formatting issues. This change aims to improve code readability and maintainability by standardizing the code style. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Ignored Files
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here. Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
Sorry, something went wrong.
There was a problem hiding this comment.
Code Review
This pull request introduces Prettier to the project for consistent code formatting, which is a great addition for maintainability. The changes include adding the necessary configuration files, package dependencies, and scripts. My review includes a minor suggestion to simplify the Prettier configuration.
Sorry, something went wrong.
Force re-run of CI checks by updating tool-normalization.ts comment. Verified local formatting passes.
- Moved lint, format, and type-check to a separate 'verify' job running once on ubuntu-latest. - 'test' job now depends on 'verify' and only runs tests across the OS/Node matrix. - Reduces redundant checks and speeds up the feedback loop.
allenhutchison
left a comment
There was a problem hiding this comment.
thanks for adding the format checking. I had to run prettier to ensure that the new tests would pass, so that added a lot of changes to the PR. I also extracted the static tests from the unit test matrix so that they only run once instead of 9 times.
Sorry, something went wrong.
Closes #180
I used Gemini CLI to make the changes here https://github.com/google-gemini/gemini-cli/blob/main/.github/workflows/ci.yml#L104